feature/port_error_counts #257

Merged
alexvanin merged 2 commits from dkirillov/frostfs-sdk-go:feature/port_error_counts into support/v1.0.0-rc.5 2024-09-04 19:51:16 +00:00
Member
No description provided.
dkirillov self-assigned this 2024-08-20 09:44:34 +00:00
dkirillov added 2 commits 2024-08-20 09:44:39 +00:00
Previously we count all frostfs errors like:
ObjectNotFound, EACLNotFound
because frostfs status is unconditionally resolved into built-in go errors
but handleError method handled built-in errors like internal network ones.
Since after resolving frostfs errors status is also returned we start check this first

Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
(cherry picked from commit 203bba65a0)
[#256] pool/tree: Add node address to error
Some checks failed
DCO / DCO (pull_request) Failing after 37s
Tests and linters / Tests (1.22) (pull_request) Successful in 50s
Tests and linters / Tests (1.21) (pull_request) Successful in 55s
Tests and linters / Lint (pull_request) Successful in 1m59s
50d6b9bbf1
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov force-pushed feature/port_error_counts from 50d6b9bbf1 to f672dfb2c5 2024-08-20 09:45:35 +00:00 Compare
dkirillov force-pushed feature/port_error_counts from f672dfb2c5 to 8484462310 2024-08-20 09:47:37 +00:00 Compare
dkirillov requested review from storage-core-committers 2024-08-20 09:48:51 +00:00
dkirillov requested review from storage-core-developers 2024-08-20 09:48:52 +00:00
dkirillov requested review from storage-sdk-committers 2024-08-20 09:48:52 +00:00
dkirillov requested review from storage-sdk-developers 2024-08-20 09:48:52 +00:00
dkirillov requested review from storage-services-committers 2024-08-20 09:48:52 +00:00
dkirillov requested review from storage-services-developers 2024-08-20 09:48:54 +00:00
alexvanin approved these changes 2024-08-20 10:05:18 +00:00
Owner

@dkirillov don't forget to port 8484462310 into master

@dkirillov don't forget to port 848446231082b8b50b2292e152cc116f0c320dbe into master
Author
Member

@dkirillov don't forget to port 8484462310 into master

#258

> @dkirillov don't forget to port 848446231082b8b50b2292e152cc116f0c320dbe into master https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/258
fyrchik approved these changes 2024-08-20 11:32:34 +00:00
alexvanin merged commit 8484462310 into support/v1.0.0-rc.5 2024-08-20 12:58:23 +00:00
alexvanin deleted branch feature/port_error_counts 2024-08-20 12:58:24 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-sdk-developers
TrueCloudLab/storage-services-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#257
No description provided.