TrueCloudLab/frostfs-sdk-go
29
0
Fork 21
Code Issues 29 Pull requests 2 Releases Activity Actions

[#203] Add pool docs #262

Merged
fyrchik merged 1 commit from nzinkevich/frostfs-sdk-go:pool_docs into master 2024-08-30 13:44:21 +00:00
Conversation 0 Commits 1 Files changed 4 +34 -4
nzinkevich commented 2024-08-29 13:00:33 +00:00
Member
Copy link
No description provided.
nzinkevich added 1 commit 2024-08-29 13:00:37 +00:00
[#203] Add pool docs
Some checks failed
DCO / DCO (pull_request) Failing after 55s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 1m2s
Details
Tests and linters / Tests (1.23) (pull_request) Successful in 1m1s
Details
Tests and linters / Lint (pull_request) Successful in 1m41s
Details
744ed4863b
nzinkevich requested review from fyrchik 2024-08-29 13:00:59 +00:00
nzinkevich force-pushed pool_docs from 744ed4863b to ce8782ffb9 2024-08-29 13:05:35 +00:00 Compare
fyrchik reviewed 2024-08-29 13:39:47 +00:00
doc/pool.md Outdated
@ -0,0 +5,4 @@
The distribution between nodes in connection pool is based on priority and weight parameters from
NodeParam struct. The distribution model is presented below. On this scheme nodes with the same
priority has the same color.
fyrchik commented 2024-08-29 13:14:52 +00:00
Owner
Copy link

s/has/have/ (nodes)

`s/has/have/` (nodes)
doc/pool.md Outdated
@ -0,0 +7,4 @@
NodeParam struct. The distribution model is presented below. On this scheme nodes with the same
priority has the same color.
![](./image/pool.png "Pool connections distribution model")
fyrchik commented 2024-08-29 13:13:21 +00:00
Owner
Copy link

Oh my god, this picture, these arrows, pure aesthetics

Oh my god, this picture, these arrows, pure aesthetics
😆 1
doc/pool.md Outdated
@ -0,0 +21,4 @@
## Weights
If there are several nodes with the same priority, then request distribution goes randomly between
fyrchik commented 2024-08-29 13:39:42 +00:00
Owner
Copy link

request distribution goes -> requests are distributed

`request distribution goes` -> `requests are distributed`
nzinkevich force-pushed pool_docs from ce8782ffb9 to 3c00f4eeac 2024-08-30 05:26:06 +00:00 Compare
aarifullin approved these changes 2024-08-30 07:03:02 +00:00
fyrchik approved these changes 2024-08-30 07:25:10 +00:00
dkirillov approved these changes 2024-08-30 12:20:35 +00:00
fyrchik merged commit 3c00f4eeac into master 2024-08-30 13:44:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
dkirillov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#262
No description provided.
Delete branch "nzinkevich/frostfs-sdk-go:pool_docs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?