TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

go.mod: Update api-go #263

Merged
fyrchik merged 1 commit from a-savchuk/frostfs-sdk-go:remove-get-eacl into master 2024-09-03 14:11:55 +00:00
Conversation 2 Commits 1 Files changed 6 +1 -248
a-savchuk commented 2024-09-02 15:16:49 +00:00
Member
Copy link

Remove client.ContainerEACL and related references. This change was initiated by the removal of ContainerService.GetExtendedACL from the API.

Initiated by this issue.

Signed-off-by: Aleksey Savchuk a.savchuk@yadro.com

Remove `client.ContainerEACL` and related references. This change was initiated by the removal of `ContainerService.GetExtendedACL` from the API. Initiated by [this issue](https://git.frostfs.info/TrueCloudLab/frostfs-api/issues/60). Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 1 commit 2024-09-02 15:17:01 +00:00
[#xx] go.mod: Update api-go,
Some checks failed
DCO / DCO (pull_request) Failing after 43s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 1m10s
Details
Tests and linters / Tests (1.23) (pull_request) Successful in 1m9s
Details
Tests and linters / Lint (pull_request) Successful in 2m18s
Details
52ba5dbf31 
Remove `client.ContainerEACL` and related references. This change
was initiated by the removal of `ContainerService.GetExtendedACL`
from the API.

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk force-pushed remove-get-eacl from 52ba5dbf31 to 689e79352b 2024-09-02 15:18:41 +00:00 Compare
a-savchuk force-pushed remove-get-eacl from 689e79352b to 0ebfa7d3b7 2024-09-02 15:20:03 +00:00 Compare
a-savchuk changed title from WIP: go.mod: Update api-go, to WIP: go.mod: Update api-go 2024-09-02 15:20:05 +00:00
a-savchuk changed title from WIP: go.mod: Update api-go to go.mod: Update api-go 2024-09-02 15:23:24 +00:00
a-savchuk requested review from storage-core-committers 2024-09-02 15:23:32 +00:00
a-savchuk requested review from storage-core-developers 2024-09-02 15:23:33 +00:00
fyrchik approved these changes 2024-09-02 17:36:21 +00:00
fyrchik requested review from storage-services-developers 2024-09-02 17:36:32 +00:00
fyrchik requested review from storage-services-committers 2024-09-02 17:36:33 +00:00
fyrchik commented 2024-09-02 17:36:41 +00:00
Owner
Copy link

Waiting for services to approve

Waiting for services to approve
acid-ant approved these changes 2024-09-03 06:20:27 +00:00
acid-ant commented 2024-09-03 06:21:14 +00:00
Member
Copy link

Please resolve conflicts.

Please resolve conflicts.
dkirillov reviewed 2024-09-03 06:30:47 +00:00
pool/pool.go Outdated
@ -580,4 +578,2 @@
}
// containerEACL invokes sdkClient.ContainerEACL parse response status to error and return result as is.
func (c *clientWrapper) containerEACL(ctx context.Context, prm PrmContainerEACL) (eacl.Table, error) {
dkirillov commented 2024-09-03 06:30:47 +00:00
Member
Copy link

Please also drop these methods (containerEACL/containerSetEACL) from mock_test.go

Please also drop these methods (`containerEACL`/`containerSetEACL`) from `mock_test.go`
a-savchuk commented 2024-09-03 07:18:07 +00:00
Author
Member
Copy link

Done

Done
dkirillov commented 2024-09-03 09:27:22 +00:00
Member
Copy link

Oh, we also should drop:

  • methodContainerSetEACL/ methodContainerEACL of MethodIndex type
  • PrmContainerSetEACL
  • PrmContainerEACL
Oh, we also should drop: * `methodContainerSetEACL`/ `methodContainerEACL` of `MethodIndex` type * `PrmContainerSetEACL` * `PrmContainerEACL`
a-savchuk commented 2024-09-03 09:40:05 +00:00
Author
Member
Copy link

Done. Feels like playing Minesweeper💣

Done. Feels like playing Minesweeper💣
dkirillov marked this conversation as resolved
a-savchuk force-pushed remove-get-eacl from 0ebfa7d3b7 to b36bdde7a8 2024-09-03 07:05:13 +00:00 Compare
a-savchuk force-pushed remove-get-eacl from b36bdde7a8 to 793c612bc8 2024-09-03 07:17:28 +00:00 Compare
a-savchuk requested review from acid-ant 2024-09-03 08:55:46 +00:00
a-savchuk requested review from fyrchik 2024-09-03 08:55:48 +00:00
a-savchuk force-pushed remove-get-eacl from 793c612bc8 to 8f751d9dd0 2024-09-03 09:36:41 +00:00 Compare
dkirillov approved these changes 2024-09-03 12:31:03 +00:00
fyrchik merged commit 8f751d9dd0 into master 2024-09-03 14:11:55 +00:00
fyrchik referenced this pull request from a commit 2024-09-03 14:11:57 +00:00
[#263] go.mod: Update api-go
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
dkirillov
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#263
No description provided.
Delete branch "a-savchuk/frostfs-sdk-go:remove-get-eacl"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?