TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 30 Pull requests 3 Releases Activity Actions

netmap: Return node netmap state directly #264

Merged
fyrchik merged 1 commit from a-savchuk/frostfs-sdk-go:netmap-state into master 2024-09-09 08:51:51 +00:00
Conversation 0 Commits 1 Files changed 2 +134 -16
a-savchuk commented 2024-09-03 15:15:50 +00:00
Member
Copy link

Close #217

Signed-off-by: Aleksey Savchuk a.savchuk@yadro.com

Close #217 Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 1 commit 2024-09-03 15:15:53 +00:00
[#217] netmap: Return node netmap state directly
All checks were successful
DCO / DCO (pull_request) Successful in 54s
Details
Tests and linters / Tests (1.23) (pull_request) Successful in 1m3s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 1m6s
Details
Tests and linters / Lint (pull_request) Successful in 1m37s
Details
3b25f94237 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk changed title from WIP: netmap: Return node netmap state directly to netmap: Return node netmap state directly 2024-09-03 15:18:26 +00:00
a-savchuk requested review from storage-core-developers 2024-09-03 15:18:40 +00:00
a-savchuk requested review from storage-core-committers 2024-09-03 15:18:41 +00:00
a-savchuk requested review from storage-services-developers 2024-09-03 15:18:41 +00:00
a-savchuk requested review from storage-services-committers 2024-09-03 15:18:42 +00:00
dstepanov-yadro approved these changes 2024-09-04 06:38:47 +00:00
dstepanov-yadro reviewed 2024-09-04 06:42:03 +00:00
netmap/node_info.go Outdated
@ -471,2 +473,4 @@
//
// See also SetOffline.
//
// Deprecated: use Status instead.
dstepanov-yadro commented 2024-09-04 06:42:03 +00:00
Member
Copy link

This methods (IsOnline, IsOffline...) should be moved to netmap.NodeState

This methods (`IsOnline`, `IsOffline`...) should be moved to `netmap.NodeState`
👍 1 👀 1
fyrchik commented 2024-09-04 10:59:12 +00:00
Owner
Copy link

For this to work, we need to define and enum here, which is a good thing anyway.

For this to work, we need to define and enum here, which is a good thing anyway.
👀 1
a-savchuk force-pushed netmap-state from 3b25f94237 to 44ea6310dc 2024-09-04 12:16:08 +00:00 Compare
fyrchik requested changes 2024-09-04 12:35:10 +00:00
Dismissed
netmap/node_info.go Outdated
@ -470,4 +506,0 @@
// mean online).
//
// See also SetOffline.
func (x NodeInfo) IsOffline() bool {
fyrchik commented 2024-09-04 12:35:07 +00:00
Owner
Copy link

Why not deprecate it first?

Why not deprecate it first?
👀 1
a-savchuk commented 2024-09-04 14:30:40 +00:00
Author
Member
Copy link

Done

Done
fyrchik marked this conversation as resolved
netmap/node_info.go Outdated
@ -479,4 +508,2 @@
// action is interpreted as an intention to enter the network.
//
// See also IsOnline.
func (x *NodeInfo) SetOnline() {
fyrchik commented 2024-09-04 12:18:23 +00:00
Owner
Copy link

Let's also add SetStatus and deprecate these SetOnline/SetOffline

Let's also add `SetStatus` and deprecate these `SetOnline`/`SetOffline`
👀 1
a-savchuk commented 2024-09-04 14:30:47 +00:00
Author
Member
Copy link

Done

Done
fyrchik marked this conversation as resolved
a-savchuk force-pushed netmap-state from 44ea6310dc to 04f30c3df4 2024-09-04 13:34:52 +00:00 Compare
a-savchuk changed title from netmap: Return node netmap state directly to WIP: netmap: Return node netmap state directly 2024-09-04 13:36:09 +00:00
a-savchuk force-pushed netmap-state from 04f30c3df4 to 1045109782 2024-09-04 14:29:27 +00:00 Compare
a-savchuk changed title from WIP: netmap: Return node netmap state directly to netmap: Return node netmap state directly 2024-09-04 14:31:08 +00:00
dstepanov-yadro approved these changes 2024-09-04 14:36:33 +00:00
a-savchuk requested review from fyrchik 2024-09-09 08:21:27 +00:00
fyrchik approved these changes 2024-09-09 08:51:46 +00:00
fyrchik merged commit 76a0cfdadb into master 2024-09-09 08:51:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
TrueCloudLab/storage-services-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#264
No description provided.
Delete branch "a-savchuk/frostfs-sdk-go:netmap-state"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?