TrueCloudLab/frostfs-sdk-go
30
0
Fork 20
Code Issues 30 Pull requests 2 Releases Activity Actions

object: Add UserAttributes method #272

Merged
dstepanov-yadro merged 2 commits from a-savchuk/frostfs-sdk-go:object-user-attrs into master 2024-09-20 07:46:49 +00:00
Conversation 0 Commits 2 Files changed 4 +48 -8
a-savchuk commented 2024-09-16 12:40:50 +00:00
Member
Copy link

Close #271

Signed-off-by: Aleksey Savchuk a.savchuk@yadro.com

Close #271 Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 1 commit 2024-09-16 12:40:51 +00:00
[#271] object: Add UserAttributes method
All checks were successful
DCO / DCO (pull_request) Successful in 42s
Details
Tests and linters / Tests (pull_request) Successful in 56s
Details
Tests and linters / Lint (pull_request) Successful in 1m40s
Details
29bdb885aa 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk requested review from storage-core-committers 2024-09-16 12:43:16 +00:00
a-savchuk requested review from storage-core-developers 2024-09-16 12:43:16 +00:00
a-savchuk requested review from storage-services-committers 2024-09-16 12:43:17 +00:00
a-savchuk requested review from storage-services-developers 2024-09-16 12:43:17 +00:00
nzinkevich approved these changes 2024-09-17 13:56:41 +00:00
Dismissed
elebedeva approved these changes 2024-09-17 14:41:54 +00:00
Dismissed
dstepanov-yadro reviewed 2024-09-18 07:13:38 +00:00
object/object.go Outdated
@ -315,0 +327,4 @@
key := attr.GetKey()
if !strings.HasPrefix(key, container.SysAttributePrefix) &&
!strings.HasPrefix(key, container.SysAttributePrefixNeoFS) {
dstepanov-yadro commented 2024-09-18 07:13:38 +00:00
Member
Copy link

You dropped NeoFS attribute handling here: https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1379/files

So I think you can drop it from frostfs-sdk too.

You dropped `NeoFS` attribute handling here: https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1379/files So I think you can drop it from frostfs-sdk too.
a-savchuk commented 2024-09-18 08:02:20 +00:00
Author
Member
Copy link

Done

Done
a-savchuk force-pushed object-user-attrs from 29bdb885aa to 9d112926a3 2024-09-18 07:58:34 +00:00 Compare
a-savchuk dismissed nzinkevich's review 2024-09-18 07:58:34 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

a-savchuk dismissed elebedeva's review 2024-09-18 07:58:35 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro requested review from storage-services-developers 2024-09-18 08:33:13 +00:00
dstepanov-yadro approved these changes 2024-09-18 08:33:22 +00:00
Dismissed
a-savchuk force-pushed object-user-attrs from 9d112926a3 to e580ee991d 2024-09-18 09:59:40 +00:00 Compare
nzinkevich approved these changes 2024-09-19 06:05:43 +00:00
dstepanov-yadro approved these changes 2024-09-20 07:46:42 +00:00
dstepanov-yadro merged commit e580ee991d into master 2024-09-20 07:46:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
nzinkevich
dstepanov-yadro
TrueCloudLab/storage-services-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#272
No description provided.
Delete branch "a-savchuk/frostfs-sdk-go:object-user-attrs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?