TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 30 Pull requests 3 Releases Activity Actions

netmap: Support non-ascii attributes in SELECT IN #273

Merged
acid-ant merged 1 commit from a-savchuk/frostfs-sdk-go:antlr-bug into master 2024-11-02 14:21:46 +00:00
Conversation 1 Commits 1 Files changed 2 +74
a-savchuk commented 2024-09-17 07:34:38 +00:00
Member
Copy link

Close #269

Signed-off-by: Aleksey Savchuk a.savchuk@yadro.com

Close #269 Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 3 commits 2024-09-17 07:34:38 +00:00 
The previous policy target generated device-specific comments
(e.g., `/home/john_doe/repos/<...>`), which could result in
unnecessary file. This behavior would confuse git and require
manual changes to resolve. The update ensures comments are now
device-agnostic, preventing unwanted changes.

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
The previous wildcard failed to properly match the ANTLR jar file.

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
[#269] Update ANTLR version 4.13.0 -> 4.13.1
All checks were successful
DCO / DCO (pull_request) Successful in 42s
Details
Tests and linters / Lint (pull_request) Successful in 1m53s
Details
Tests and linters / Tests (pull_request) Successful in 50s
Details
5462c58acb 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk commented 2024-09-17 07:43:30 +00:00
Author
Member
Copy link

Duplicate the commit message body for Makefile policy target:

The previous policy target generated device-specific comments (e.g., /home/john_doe/repos/<...>), which could result in unnecessary file changes. This behavior would confuse git and require manual changes to resolve. The update ensures comments are now device-agnostic, preventing unwanted changes.

Duplicate the commit message body for Makefile policy target: > The previous policy target generated device-specific comments (e.g., `/home/john_doe/repos/<...>`), which could result in unnecessary file changes. This behavior would confuse git and require manual changes to resolve. The update ensures comments are now device-agnostic, preventing unwanted changes.
a-savchuk force-pushed antlr-bug from 5462c58acb to e3a0506da3 2024-09-17 07:45:52 +00:00 Compare
a-savchuk changed title from WIP: Support non-ascii attributes in SELECT IN to WIP: netmap: Support non-ascii attributes in SELECT IN 2024-09-17 09:16:57 +00:00
a-savchuk added 2 commits 2024-09-17 09:20:02 +00:00 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
[#269] netmap: Regenerate policy parser
All checks were successful
DCO / DCO (pull_request) Successful in 42s
Details
Tests and linters / Tests (pull_request) Successful in 54s
Details
Tests and linters / Lint (pull_request) Successful in 1m27s
Details
cf997b58b9 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 1 commit 2024-09-17 14:33:51 +00:00
[#269] netmap: Add tests for non-ascii attributes in SELECT IN
Some checks failed
DCO / DCO (pull_request) Successful in 41s
Details
Tests and linters / Lint (pull_request) Successful in 1m22s
Details
Tests and linters / Tests (pull_request) Failing after 45s
Details
04cf704010 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk force-pushed antlr-bug from 04cf704010 to 116cfcbf7b 2024-09-17 14:44:56 +00:00 Compare
a-savchuk force-pushed antlr-bug from 116cfcbf7b to 9379d4140f 2024-09-17 14:45:47 +00:00 Compare
a-savchuk force-pushed antlr-bug from 9379d4140f to 527e893872 2024-09-17 14:49:31 +00:00 Compare
a-savchuk force-pushed antlr-bug from 527e893872 to 1ac1e5007b 2024-09-19 08:31:37 +00:00 Compare
a-savchuk force-pushed antlr-bug from 1ac1e5007b to 9b2ae8d4d9 2024-09-19 10:15:53 +00:00 Compare
a-savchuk changed title from WIP: netmap: Support non-ascii attributes in SELECT IN to netmap: Support non-ascii attributes in SELECT IN 2024-09-19 10:18:26 +00:00
a-savchuk requested review from storage-core-committers 2024-09-19 10:18:38 +00:00
a-savchuk requested review from storage-core-developers 2024-09-19 10:18:39 +00:00
a-savchuk requested review from storage-services-committers 2024-09-19 10:18:39 +00:00
a-savchuk requested review from storage-services-developers 2024-09-19 10:18:40 +00:00
dstepanov-yadro approved these changes 2024-09-19 12:57:59 +00:00
a-savchuk force-pushed antlr-bug from 9b2ae8d4d9 to 99d5bf913b 2024-09-20 11:09:17 +00:00 Compare
nzinkevich approved these changes 2024-09-20 13:29:51 +00:00
acid-ant approved these changes 2024-09-23 09:20:19 +00:00
acid-ant merged commit 99d5bf913b into master 2024-09-23 09:20:42 +00:00
a-savchuk deleted branch antlr-bug 2024-09-23 09:23:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
nzinkevich
acid-ant
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#273
No description provided.
Delete branch "a-savchuk/frostfs-sdk-go:antlr-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?