TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

Use DialTimeout for gRPC dial #280

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-sdk-go:fix/use_dial_timeout into master 2024-10-08 06:56:22 +00:00
Conversation 0 Commits 1 Files changed 1 +2
dstepanov-yadro commented 2024-10-07 13:57:36 +00:00
Member
Copy link

After removing grpc.Dial from client DialTimeout used only if custom dialer provided. Client uses BalanceOf instead of grpc.Dial,so it is required to use DialTimeout to not to use RPC timeout.

After removing `grpc.Dial` from client `DialTimeout` used only if custom dialer provided. Client uses `BalanceOf` instead of `grpc.Dial`,so it is required to use `DialTimeout` to not to use RPC timeout.
dstepanov-yadro added 1 commit 2024-10-07 13:57:37 +00:00
[#9999] client: Use DialTimeout for gRPC dial
All checks were successful
DCO / DCO (pull_request) Successful in 47s
Details
Tests and linters / Tests (pull_request) Successful in 1m25s
Details
Tests and linters / Lint (pull_request) Successful in 1m56s
Details
ccbf007e5d 
After removing `grpc.Dial` from client `DialTimeout` used only if
custom dialer provided. Client uses `BalanceOf` instead of `grpc.Dial`,
so it is required to use `DialTimeout` to not to use RPC timeout.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/use_dial_timeout from ccbf007e5d to 4c310ae1c7 2024-10-07 13:58:34 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-10-07 13:59:30 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-10-07 13:59:35 +00:00
fyrchik approved these changes 2024-10-07 18:02:15 +00:00
acid-ant approved these changes 2024-10-08 05:43:24 +00:00
dstepanov-yadro merged commit 4c310ae1c7 into master 2024-10-08 06:56:22 +00:00
dstepanov-yadro deleted branch fix/use_dial_timeout 2024-10-08 06:56:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#280
No description provided.
Delete branch "dstepanov-yadro/frostfs-sdk-go:fix/use_dial_timeout"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?