TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 30 Pull requests 3 Releases Activity Actions

WIP: client: Pass grpc.CallOption options on dial #287

Closed
a-savchuk wants to merge 3 commits from a-savchuk/frostfs-sdk-go:correct-deadline-with-wait-for-ready into master
pull from: a-savchuk/frostfs-sdk-go:correct-deadline-with-wait-for-ready
merge into: TrueCloudLab:master
Conversation 1 Commits 3 Files changed 3 +24 -17
a-savchuk commented 2024-10-16 15:24:15 +00:00
Member
Copy link

Use the feature introduced in TrueCloudLab/frostfs-api-go#124

Signed-off-by: Aleksey Savchuk a.savchuk@yadro.com

Use the feature introduced in https://git.frostfs.info/TrueCloudLab/frostfs-api-go/pulls/124 Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk added 3 commits 2024-10-16 15:24:16 +00:00 
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
[#xx] client: Fix error handling after dialing
Some checks failed
DCO / DCO (pull_request) Failing after 1m6s
Details
Tests and linters / Tests (pull_request) Successful in 1m15s
Details
Tests and linters / Lint (pull_request) Successful in 1m59s
Details
8e8ecb0716 
Before, when error was presented and neither `Canceled` nor
`DeadlineExceeded`, that method returned no error on failed dial.

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk force-pushed correct-deadline-with-wait-for-ready from 8e8ecb0716 to a611c052ac 2024-10-16 15:25:02 +00:00 Compare
a-savchuk force-pushed correct-deadline-with-wait-for-ready from a611c052ac to e44fe4bde0 2024-10-17 08:57:05 +00:00 Compare
a-savchuk force-pushed correct-deadline-with-wait-for-ready from e44fe4bde0 to 7404838a83 2024-10-17 08:58:40 +00:00 Compare
a-savchuk commented 2024-10-22 07:47:06 +00:00
Author
Member
Copy link

Found a simpler solution, please see TrueCloudLab/frostfs-node#1441

Found a simpler solution, please see https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1441
a-savchuk closed this pull request 2024-10-22 07:47:10 +00:00
All checks were successful
DCO / DCO (pull_request) Successful in 56s
Details
Tests and linters / Tests (pull_request) Successful in 1m12s
Details
Tests and linters / Lint (pull_request) Successful in 1m29s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#287
No description provided.
Delete branch "a-savchuk/frostfs-sdk-go:correct-deadline-with-wait-for-ready"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?