[#185] Implement rpc/client for tree service #299

nzinkevich · 2024-11-20T13:57:51Z

nzinkevich commented

2024-11-20 13:57:51 +00:00

Signed-off-by: Nikita Zinkevich n.zinkevich@yadro.com

Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>

nzinkevich self-assigned this 2024-11-20 13:57:51 +00:00

nzinkevich added 1 commit 2024-11-20 13:57:52 +00:00

[#185 ] Implement rpc/client for tree service

DCO / DCO (pull_request) Successful in 1m4s

Details

Tests and linters / Tests (pull_request) Successful in 1m24s

Details

Tests and linters / Lint (pull_request) Successful in 2m5s

Details

4a9a3572fa

Signed-off-by: Nikita Zinkevich <n.zinkevich@yadro.com>

nzinkevich requested review from storage-services-committers 2024-11-20 13:59:15 +00:00

nzinkevich requested review from storage-services-developers 2024-11-20 13:59:16 +00:00

aarifullin reviewed 2024-11-20 17:07:31 +00:00

api/tree/types.go

					
				@ -0,0 +352,4 @@

						return r.body

					}

					return new(HealthcheckRequestBody)

aarifullin commented

2024-11-20 17:07:30 +00:00

Why does this method return dummy value instead nil?

Why does this method return dummy value instead `nil`?

aarifullin reviewed 2024-11-20 17:17:25 +00:00

api/tree/types.go

					
				@ -0,0 +308,4 @@

				type ApplyRequestBody struct {

					ContainerID []byte

					TreeID      string

					Operation   *LogMove

aarifullin commented

2024-11-20 17:17:25 +00:00

Even this fields (not only this, but also the rest in this file) is directly accessible from this struct instance, you don't provide any getters to make the usage safe. If a client code directly uses Operation, then it may get big-boom if it will access LogMove fields when it's actually nil.

Don't you consider to make all fields private as we do for all api-go related types? And provide Get/Set methods?

Even this fields (not only this, but also the rest in this file) is directly accessible from this struct instance, you don't provide any getters to make the usage safe. If a client code directly uses `Operation`, then it may get big-boom if it will access `LogMove` fields when it's actually `nil`. Don't you consider to make all fields private as we do for all api-go related types? And provide `Get/Set` methods?