TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

[SUPPORT]: Ignore ECInfoErr erros in GetSplitInfo #313

Merged
fyrchik merged 1 commit from aarifullin/frostfs-sdk-go:fix/ignore_ec_info_err into support/v1.0.0-rc.5 2024-12-12 07:12:50 +00:00
Conversation 2 Commits 1 Files changed 1 +2 -1
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pool/pool.go
View file

@ -2985,11 +2985,12 @@ func (p *Pool) GetSplitInfo(ctx context.Context, cnrID cid.ID, objID oid.ID, tok
_, err := p.HeadObject(ctx, prm)
var errSplit *object.SplitInfoError
var errECInfo *object.ECInfoError
switch {
case errors.As(err, &errSplit):
return errSplit.SplitInfo(), nil
case err == nil:
case err == nil || errors.As(err, &errECInfo):
elebedeva marked this conversation as resolved
elebedeva commented 2024-12-11 16:00:37 +00:00
Review
Copy link

Why using errors.As() here and not errors.Is()?

Why using `errors.As()` here and not `errors.Is()`?
alexvanin commented 2024-12-12 06:32:47 +00:00
Review
Copy link

errors.Is checks exact error value (similar to == check) while errors.As tries to cast error to error type.

Exact value check is being used when error is explicitly defined (e.g. MyError := errors.New("my error").

returnedError := object.NewECInfoError(&object.ECInfo{
	Chunks: []v2object.ECChunk{{Index: 1, Total: 2}},
})

// Try to check error
var errECInfo *object.ECInfoError
fmt.Println(errors.Is(returnedError, errECInfo))  // false
fmt.Println(errors.As(returnedError, &errECInfo)) // true
`errors.Is` checks exact error value (similar to `==` check) while `errors.As` tries to cast error to error type. Exact value check is being used when error is explicitly defined (e.g. `MyError := errors.New("my error"`). ```go returnedError := object.NewECInfoError(&object.ECInfo{ Chunks: []v2object.ECChunk{{Index: 1, Total: 2}}, }) // Try to check error var errECInfo *object.ECInfoError fmt.Println(errors.Is(returnedError, errECInfo)) // false fmt.Println(errors.As(returnedError, &errECInfo)) // true ```
aarifullin commented 2024-12-12 07:06:29 +00:00
Review
Copy link

@alexvanin is right.
errors.Is would have been used if var errECInfo = errors.New("object not found, ec info provided"), but it's introduced as complex type with data within

@alexvanin is right. `errors.Is` would have been used if `var errECInfo = errors.New("object not found, ec info provided")`, but it's introduced as complex type with data within
return nil, relations.ErrNoSplitInfo
default:
return nil, fmt.Errorf("failed to get raw object header: %w", err)