TrueCloudLab/frostfs-sdk-go
32
0
Fork 21
Code Issues 32 Pull requests 2 Releases Activity Actions

Fix mem leak #324

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-sdk-go:fix/client_mem_leak into master 2025-01-29 14:22:31 +00:00
Conversation 0 Commits 1 Files changed 1 +8 -1
dstepanov-yadro commented 2025-01-29 13:33:58 +00:00
Member
Copy link

Correctly stop timer and cancel context.

Correctly stop timer and cancel context.
👍 1
dstepanov-yadro added 1 commit 2025-01-29 13:33:58 +00:00
[#9999] rpc: Fix mem leak
All checks were successful
DCO / DCO (pull_request) Successful in 26s
Details
Code generation / Generate proto (pull_request) Successful in 34s
Details
Tests and linters / Tests (pull_request) Successful in 45s
Details
Tests and linters / Lint (pull_request) Successful in 2m45s
Details
a455ba2f7b 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers, storage-services-committers, storage-services-developers 2025-01-29 13:33:58 +00:00
dstepanov-yadro force-pushed fix/client_mem_leak from a455ba2f7b to d195cb5104 2025-01-29 13:34:59 +00:00 Compare
fyrchik reviewed 2025-01-29 13:46:00 +00:00
api/rpc/client/init.go
@ -62,3 +63,3 @@
// which is not desired for the stream's lifecycle management.
dialTimeoutTimer := time.NewTimer(c.dialTimeout)
defer dialTimeoutTimer.Stop()
defer func() {
fyrchik commented 2025-01-29 13:46:00 +00:00
Owner
Copy link

So we were ahead of time!

So we were ahead of time!
fyrchik approved these changes 2025-01-29 13:46:04 +00:00
a-savchuk approved these changes 2025-01-29 13:46:43 +00:00
aarifullin approved these changes 2025-01-29 14:01:56 +00:00
dstepanov-yadro merged commit d195cb5104 into master 2025-01-29 14:22:31 +00:00
dstepanov-yadro referenced this pull request from a commit 2025-01-29 14:22:33 +00:00
[#324] rpc: Fix mem leak
dstepanov-yadro deleted branch fix/client_mem_leak 2025-01-29 14:22:33 +00:00
fyrchik referenced this pull request from a commit 2025-01-29 15:25:55 +00:00
[#324] rpc: Fix mem leak
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
a-savchuk
aarifullin
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#324
No description provided.
Delete branch "dstepanov-yadro/frostfs-sdk-go:fix/client_mem_leak"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?