rpc: Fix mem leak (support) #328

Merged

fyrchik merged 1 commit from dstepanov-yadro/frostfs-sdk-go:fix/memleak_support_rc6_2 into support/v1.0.0-rc.6

2025-01-30 12:18:08 +00:00

dstepanov-yadro commented

2025-01-30 11:06:13 +00:00

Member

gRPC stream must be closed by cancel to prevent memleak.

Clones #327

gRPC stream must be closed by `cancel` to prevent memleak. Clones https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/327

dstepanov-yadro added 1 commit 2025-01-30 11:06:13 +00:00

[#327 ] rpc: Fix mem leak

DCO / DCO (pull_request) Successful in 26s

Details

Tests and linters / Tests (pull_request) Successful in 45s

Details

Tests and linters / Lint (pull_request) Successful in 1m35s

Details

bff5c1bcdf

gRPC stream must be closed by `cancel` to prevent memleak.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

requested reviews from storage-core-committers, storage-core-developers, storage-services-committers, storage-services-developers

2025-01-30 11:06:14 +00:00

acid-ant approved these changes 2025-01-30 11:33:08 +00:00

dstepanov-yadro changed title from ~~rpc: Fix mem leak~~ to rpc: Fix mem leak (support)

2025-01-30 11:35:04 +00:00

fyrchik requested changes 2025-01-30 11:46:28 +00:00

fyrchik left a comment

Owner

We already have rpc: Fix mem leak in our commit history.
It says nothing (kinda like Fix bug, but a bit more specific).
If different commits have the same message, then the message doesn't serve its purpose, it is a bad message.
Please, adjust.
The suggestion is rpc: Cancel context after stream close feel free to choose anything you want.

We already have `rpc: Fix mem leak` in our commit history. It says nothing (kinda like `Fix bug`, but a bit more specific). If different commits have the same message, then the message doesn't serve its purpose, it is a _bad_ message. Please, adjust. The suggestion is `rpc: Cancel context after stream close` feel free to choose anything you want.

dstepanov-yadro force-pushed fix/memleak_support_rc6_2 from bff5c1bcdf to 3264317b63

2025-01-30 12:14:34 +00:00

Compare

dstepanov-yadro commented

2025-01-30 12:15:31 +00:00

Author

Member

We already have rpc: Fix mem leak in our commit history.
It says nothing (kinda like Fix bug, but a bit more specific).
If different commits have the same message, then the message doesn't serve its purpose, it is a bad message.
Please, adjust.
The suggestion is rpc: Cancel context after stream close feel free to choose anything you want.

Ok, changed. But I absolutely disagree. The commit header should describe what was done, not how.

> We already have `rpc: Fix mem leak` in our commit history. > It says nothing (kinda like `Fix bug`, but a bit more specific). > If different commits have the same message, then the message doesn't serve its purpose, it is a _bad_ message. > Please, adjust. > The suggestion is `rpc: Cancel context after stream close` feel free to choose anything you want. Ok, changed. But I absolutely disagree. The commit header should describe what was done, not how.