TrueCloudLab/frostfs-sdk-go
32
0
Fork 21
Code Issues 31 Pull requests 3 Releases Activity Actions

WIP: Use DeadlineExceeded error when creating stream failed by timeout support #335

Draft
dstepanov-yadro wants to merge 1 commit from dstepanov-yadro/frostfs-sdk-go:fix/api_client_timeout_error_support into support/v1.0.0-rc.6
pull from: dstepanov-yadro/frostfs-sdk-go:fix/api_client_timeout_error_support
merge into: TrueCloudLab:support/v1.0.0-rc.6
Conversation 0 Commits 1 Files changed 1 +1 -1
dstepanov-yadro commented 2025-02-18 06:51:08 +00:00
Member
Copy link

Clone #334

Clone https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/334
dstepanov-yadro added 1 commit 2025-02-18 06:51:08 +00:00
[#334] rpc: Use DeadlineExceeded error when creating stream failed by timeout
All checks were successful
DCO / DCO (pull_request) Successful in 31s
Details
Tests and linters / Tests (pull_request) Successful in 47s
Details
Tests and linters / Lint (pull_request) Successful in 2m7s
Details
d1ef291c64 
According to https://pkg.go.dev/context#pkg-variables, ContextCancelled
should be returned when the context is canceled for some reason other
than its deadline passing. So creating gRPC stream with dial timeout fits
better for context.DeadlineExceeded.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro changed title from WIP: Use DeadlineExceeded error when creating stream failed by timeout to WIP: Use DeadlineExceeded error when creating stream failed by timeout support 2025-02-18 07:09:24 +00:00
All checks were successful
DCO / DCO (pull_request) Successful in 31s
Details
Tests and linters / Tests (pull_request) Successful in 47s
Details
Tests and linters / Lint (pull_request) Successful in 2m7s
Details
This pull request is marked as a work in progress.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/api_client_timeout_error_support:dstepanov-yadro-fix/api_client_timeout_error_support
git checkout dstepanov-yadro-fix/api_client_timeout_error_support
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#335
No description provided.
Delete branch "dstepanov-yadro/frostfs-sdk-go:fix/api_client_timeout_error_support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?