TrueCloudLab/frostfs-sdk-go
32
0
Fork 21
Code Issues 31 Pull requests 3 Releases Activity Actions

[#336] pool/tree: Do probe in getSubTree to handle error in advance #337

Merged
alexvanin merged 2 commits from dkirillov/frostfs-sdk-go:bugfix/336-pool_tree_not_found into master 2025-02-28 10:14:26 +00:00
Conversation 1 Commits 2 Files changed 2 +139 -6
dkirillov commented 2025-02-28 08:00:47 +00:00
Member
Copy link

close #336

close #336
dkirillov self-assigned this 2025-02-28 08:00:48 +00:00
dkirillov added 1 commit 2025-02-28 08:00:48 +00:00
[#336] pool/tree: Do probe in getSubTree to handle error in advance
All checks were successful
DCO / DCO (pull_request) Successful in 28s
Details
Code generation / Generate proto (pull_request) Successful in 33s
Details
Tests and linters / Tests (pull_request) Successful in 45s
Details
Tests and linters / Lint (pull_request) Successful in 1m35s
Details
ada0513504 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
requested reviews from storage-core-developers, storage-services-committers, storage-services-developers, storage-core-committers 2025-02-28 08:00:48 +00:00
alexvanin added 1 commit 2025-02-28 09:33:16 +00:00
[#336] pool/tree: Increase test coverage in TestStreamRetry
All checks were successful
DCO / DCO (pull_request) Successful in 26s
Details
Code generation / Generate proto (pull_request) Successful in 33s
Details
Tests and linters / Tests (pull_request) Successful in 44s
Details
Tests and linters / Lint (pull_request) Successful in 1m36s
Details
2b8329e026 
Signed-off-by: Alex Vanin <a.vanin@yadro.com>
alexvanin commented 2025-02-28 09:36:49 +00:00
Owner
Copy link

In 2b8329e026 increased coverage from 50% to 57% and checked new probe field.

In https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/commit/2b8329e026c74d310817938c6cb8243749d0d49e increased coverage from 50% to 57% and checked new probe field.
alexvanin approved these changes 2025-02-28 09:43:39 +00:00
alexvanin merged commit 2b8329e026 into master 2025-02-28 10:14:26 +00:00
alexvanin deleted branch bugfix/336-pool_tree_not_found 2025-02-28 10:14:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#337
No description provided.
Delete branch "dkirillov/frostfs-sdk-go:bugfix/336-pool_tree_not_found"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?