TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

client: Refactor container methods #50

Merged
fyrchik merged 1 commit from fyrchik/frostfs-sdk-go:refactor into master 2023-07-26 21:08:02 +00:00
Conversation 1 Commits 1 Files changed 1 +23 -32
fyrchik commented 2023-04-13 06:05:23 +00:00
Owner
Copy link

From callback hell to flat heaven.

Related #48.

From callback hell to flat heaven. Related #48.
❤️ 1
fyrchik force-pushed refactor from a7129cf2a4 to d752eda64d 2023-04-13 06:05:44 +00:00 Compare
fyrchik requested review from storage-core-committers 2023-04-13 06:05:47 +00:00
fyrchik requested review from storage-core-developers 2023-04-13 06:05:47 +00:00
fyrchik requested review from storage-services-developers 2023-04-13 06:05:53 +00:00
fyrchik requested review from storage-services-committers 2023-04-13 06:05:53 +00:00
fyrchik force-pushed refactor from d752eda64d to be9fd0c976 2023-04-13 06:15:59 +00:00 Compare
fyrchik force-pushed refactor from be9fd0c976 to a7b61ef8a8 2023-04-13 06:19:13 +00:00 Compare
dstepanov-yadro approved these changes 2023-04-13 07:54:23 +00:00
dkirillov approved these changes 2023-04-13 12:11:05 +00:00
carpawell commented 2023-04-13 13:25:43 +00:00
Contributor
Copy link

May it look better if commits would have container suffix? Like [#48] client/container: Refactor ContainerGet()?

Otherwise, we will have plenty of [#48] client: Form requests in a separate function commits.

May it look better if commits would have `container` suffix? Like `[#48] client/container: Refactor ContainerGet()`? Otherwise, we will have plenty of `[#48] client: Form requests in a separate function` commits.
acid-ant approved these changes 2023-04-13 13:42:04 +00:00
fyrchik force-pushed refactor from a7b61ef8a8 to 591dd1247d 2023-04-14 06:08:01 +00:00 Compare
fyrchik merged commit 591dd1247d into master 2023-04-14 06:08:13 +00:00
fyrchik deleted branch refactor 2023-04-14 06:08:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
dkirillov
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#50
No description provided.
Delete branch "fyrchik/frostfs-sdk-go:refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?