TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

Update antlr4 version to 4.13.0 #81

Merged
fyrchik merged 2 commits from acid-ant/frostfs-sdk-go:bugfix/75-antlr4-in-docker into master 2023-06-01 13:15:13 +00:00
Conversation 0 Commits 2 Files changed 9 +501 -381
acid-ant commented 2023-05-30 07:04:39 +00:00
Member
Copy link

Add make targets policy and docker/%.

Close #75

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Add `make` targets `policy` and `docker/%`. Close #75 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-committers 2023-05-30 07:04:57 +00:00
acid-ant requested review from storage-core-developers 2023-05-30 07:04:57 +00:00
fyrchik reviewed 2023-05-30 09:23:19 +00:00
README.md Outdated
@ -121,6 +121,24 @@ func placementNodes(addr *object.Address, p *netmap.PlacementPolicy, frostfsNode
}
```
#### antlr commands to update parsers
fyrchik commented 2023-05-30 09:23:19 +00:00
Owner
Copy link

What about writing a Make target for this?
I mean we also have a specific version and dockerfile is rather simple, so storing just dockerfile is an option.
We seem to download everything in Docker anyway.

What about writing a Make target for this? I mean we also have a specific version and dockerfile is rather simple, so storing just dockerfile is an option. We seem to download everything in Docker anyway.
fyrchik commented 2023-05-30 09:26:30 +00:00
Owner
Copy link

Maybe we even can add this to go:generate: it's just docker docker build and docker run.

Maybe we even can add this to `go:generate`: it's just docker docker build and docker run.
acid-ant commented 2023-05-30 12:49:55 +00:00
Author
Member
Copy link

Added two targets antlr-image and antlr-run. @realloc that is what you need?

Added two targets `antlr-image` and `antlr-run`. @realloc that is what you need?
fyrchik commented 2023-05-31 10:24:23 +00:00
Owner
Copy link

I think the intention was to have
make policy and make docker/policy, where the first one runs the first target in the docker container.
On a side-note, I think it makes sense to build in the same target, I can't imagine the use-case for a separate target here.

I think the intention was to have `make policy` and `make docker/policy`, where the first one runs the first target in the docker container. On a side-note, I think it makes sense to build in the same target, I can't imagine the use-case for a separate target here.
👍 1
acid-ant commented 2023-05-31 11:54:19 +00:00
Author
Member
Copy link

Added, please review.

Added, please review.
fyrchik commented 2023-05-31 13:23:16 +00:00
Owner
Copy link

Can we make it similar to this one?

Line 104 in TrueCloudLab/frostfs-node@dbf4139
docker/%:

Can we make it similar to this one? https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/dbf41391b55992decff4e55b9c3480874af3cde3/Makefile#L104
acid-ant commented 2023-05-31 14:05:44 +00:00
Author
Member
Copy link

Done.

Done.
fyrchik marked this conversation as resolved
aarifullin approved these changes 2023-05-30 09:29:17 +00:00
aarifullin approved these changes 2023-05-31 09:11:38 +00:00
acid-ant force-pushed bugfix/75-antlr4-in-docker from b54f3461b7 to 3f6c44f13d 2023-05-31 11:53:26 +00:00 Compare
aarifullin approved these changes 2023-05-31 13:19:48 +00:00
acid-ant force-pushed bugfix/75-antlr4-in-docker from 3f6c44f13d to 3f3a65be53 2023-05-31 14:05:31 +00:00 Compare
acid-ant force-pushed bugfix/75-antlr4-in-docker from 3f3a65be53 to 29fc6288fe 2023-05-31 14:23:20 +00:00 Compare
acid-ant force-pushed bugfix/75-antlr4-in-docker from 29fc6288fe to 86f5468506 2023-06-01 06:15:58 +00:00 Compare
acid-ant changed title from Update antlr4 version to 4.13.0 to WIP: Update antlr4 version to 4.13.0 2023-06-01 06:27:16 +00:00
acid-ant force-pushed bugfix/75-antlr4-in-docker from 86f5468506 to 4592f7f24d 2023-06-01 06:32:33 +00:00 Compare
acid-ant force-pushed bugfix/75-antlr4-in-docker from 4592f7f24d to 857c4bfda4 2023-06-01 07:26:42 +00:00 Compare
acid-ant changed title from WIP: Update antlr4 version to 4.13.0 to Update antlr4 version to 4.13.0 2023-06-01 07:26:53 +00:00
aarifullin approved these changes 2023-06-01 10:58:30 +00:00
fyrchik approved these changes 2023-06-01 13:15:01 +00:00
Makefile Outdated
@ -32,0 +36,4 @@
@java -Xmx500M -cp "`pwd`/antlr4-tool.jar" "org.antlr.v4.Tool" -o `pwd`/netmap/parser/ -Dlanguage=Go -no-listener -visitor `pwd`/netmap/parser/Query.g4 `pwd`/netmap/parser/QueryLexer.g4
docker/policy:
@docker build -q -t antlr/antlr4 --platform linux/amd64 . > /dev/null
fyrchik commented 2023-05-31 12:29:59 +00:00
Owner
Copy link

Do we need to specify platform?

Do we need to specify platform?
fyrchik merged commit 0f7455ff7a into master 2023-06-01 13:15:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#81
No description provided.
Delete branch "acid-ant/frostfs-sdk-go:bugfix/75-antlr4-in-docker"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?