TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 29 Pull requests 2 Releases Activity Actions

[#76] Add UNIQUE keyword #89

Merged
acid-ant merged 1 commit from ale64bit/frostfs-sdk-go:feat/76-add-unique-keyword into master 2023-06-07 12:26:38 +00:00
Conversation 2 Commits 1 Files changed 17 +423 -279
ale64bit commented 2023-06-05 10:40:12 +00:00
Member
Copy link

Signed-off-by: Alejandro Lopez a.lopez@yadro.com
Closes #76

Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Closes #76
ale64bit requested review from storage-core-committers 2023-06-05 10:40:26 +00:00
ale64bit requested review from storage-core-developers 2023-06-05 10:40:26 +00:00
aarifullin reviewed 2023-06-05 11:02:44 +00:00
netmap/parser/generate.go Outdated
@ -2,3 +2,2 @@
// ANTLR can be downloaded from https://www.antlr.org/download/antlr-4.12.0-complete.jar
//go:generate java -Xmx500M -cp "./antlr-4.12.0-complete.jar:$CLASSPATH" org.antlr.v4.Tool -Dlanguage=Go -no-listener -visitor QueryLexer.g4 Query.g4
// ANTLR can be downloaded from https://www.antlr.org/download/antlr-4.13.0-complete.jar
aarifullin commented 2023-06-05 11:02:44 +00:00
Member
Copy link

BTW, do you think this is still usable? @acid-ant introduced make-option for parser generating

BTW, do you think this is still usable? @acid-ant introduced `make`-option for parser generating
ale64bit commented 2023-06-05 11:05:34 +00:00
Author
Member
Copy link

I'm not sure. I just updated the version so that they match at least.

I'm not sure. I just updated the version so that they match at least.
👍 1
aarifullin approved these changes 2023-06-05 11:09:34 +00:00
aarifullin left a comment
Member
Copy link

LGTM

LGTM
acid-ant approved these changes 2023-06-05 15:39:10 +00:00
ale64bit commented 2023-06-06 07:05:43 +00:00
Author
Member
Copy link

Please don't merge yet. There's something I need to add/fix.

Please don't merge yet. There's something I need to add/fix.
ale64bit force-pushed feat/76-add-unique-keyword from d4a76f22f8 to fcbf96add6 2023-06-06 10:54:15 +00:00 Compare
ale64bit requested review from aarifullin 2023-06-06 10:54:26 +00:00
ale64bit requested review from acid-ant 2023-06-06 10:54:28 +00:00
ale64bit commented 2023-06-06 10:55:27 +00:00
Author
Member
Copy link

Apologies, didn't realize that the logic for node selection lived in this repo and not in frostfs-node. I added the implementation of UNIQUE to this PR now. The change is purely additive, the previous changes remain the same.

Apologies, didn't realize that the logic for node selection lived in this repo and not in frostfs-node. I added the implementation of `UNIQUE` to this PR now. The change is purely additive, the previous changes remain the same.
acid-ant approved these changes 2023-06-06 14:20:26 +00:00
ale64bit requested review from storage-core-developers 2023-06-07 07:03:28 +00:00
ale64bit requested review from storage-core-committers 2023-06-07 07:03:41 +00:00
dstepanov-yadro approved these changes 2023-06-07 07:53:25 +00:00
aarifullin approved these changes 2023-06-07 12:11:44 +00:00
aarifullin left a comment
Member
Copy link

Nice!

Nice!
acid-ant merged commit fcbf96add6 into master 2023-06-07 12:26:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#89
No description provided.
Delete branch "ale64bit/frostfs-sdk-go:feat/76-add-unique-keyword"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?