[#14] add lombok and refactor exceptions. #15

orikik · 2024-09-17T14:48:20Z

orikik commented

2024-09-17 14:48:20 +00:00

Also provide validator

orikik added 1 commit 2024-09-17 14:48:21 +00:00

[#14 ] add lombok and refactor exceptions. Provide validator.

DCO / DCO (pull_request) Successful in 34s

Details

388428af76

Signed-off-by: Ori Bruk <o.bruk@yadro.com>

orikik requested review from pogpp 2024-09-17 14:49:12 +00:00

orikik requested review from PavelGrossSpb 2024-09-17 14:49:13 +00:00

pogpp reviewed 2024-09-18 06:40:27 +00:00

README.md Outdated

					
				@ -36,3 +36,3 @@

				        // Create container

				        var placementPolicy = new PlacementPolicy(true, new Replica[]{new Replica(1)});

				        var placementPolicy = new PlacementPolicy(new Replica[]{new Replica(1)}, true);

pogpp commented

2024-09-18 06:40:26 +00:00

best practice is to use Boolean.TRUE?

orikik commented

2024-09-18 07:29:39 +00:00

From a performance perspective this will only make things worse because the primitive will suffice. But for ease of reading, yes, I will correct it.

pogpp commented

2024-09-18 10:30:53 +00:00

From a performance perspective this will only make things worse because the primitive will suffice. But for ease of reading, yes, I will correct it.

https://www.linkedin.com/pulse/low-latency-optimisation-jvmpart-2-jvm-optimisations-steve-ball/

> From a performance perspective this will only make things worse because the primitive will suffice. But for ease of reading, yes, I will correct it. https://www.linkedin.com/pulse/low-latency-optimisation-jvmpart-2-jvm-optimisations-steve-ball/

orikik added 1 commit 2024-09-18 07:33:58 +00:00

[#14 ] code review fix

DCO / DCO (pull_request) Successful in 37s

Details

59356180d5

Signed-off-by: Ori Bruk <o.bruk@yadro.com>

pogpp approved these changes 2024-09-18 10:28:40 +00:00

orikik merged commit 59356180d5 into master

2024-09-18 10:40:14 +00:00

orikik deleted branch feature/lombok_and_exceptions

2024-09-18 10:40:15 +00:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-java#15