TrueCloudLab/frostfs-sdk-java
17
0
Fork 3
Code Issues 4 Pull requests 1 Releases Packages Activity Actions

[#16] Add GRPC metrics interceptor #17

Merged
pogpp merged 1 commit from pogpp/frostfs-sdk-java:feature/16_grpc_interceptors into master 2024-10-02 08:44:12 +00:00
Conversation 1 Commits 1 Files changed 10 +587 -3
pogpp commented 2024-09-27 11:55:10 +00:00
Member
Copy link

grpc_client_started_total: Total number of RPCs started on the client.
grpc_client_completed: Total number of RPCs completed on the client, regardless of success or failure.
grpc_client_completed_latency_seconds: (Optional) Histogram of rpc response latency for completed rpcs, in seconds.
grpc_client_msg_received_total: Total number of stream messages received from the server.
grpc_client_msg_sent_total: Total number of stream messages sent by the client.

Signed-off-by: Pavel Pogodaev p.pogodaev@yadro.com

grpc_client_started_total: Total number of RPCs started on the client. grpc_client_completed: Total number of RPCs completed on the client, regardless of success or failure. grpc_client_completed_latency_seconds: (Optional) Histogram of rpc response latency for completed rpcs, in seconds. grpc_client_msg_received_total: Total number of stream messages received from the server. grpc_client_msg_sent_total: Total number of stream messages sent by the client. Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp added 1 commit 2024-09-27 11:55:10 +00:00
[#16] Add GRPC metrics interceptor
All checks were successful
DCO / DCO (pull_request) Successful in 45s
Details
ff74e5b0a1 
Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp requested review from orikik 2024-09-27 11:55:27 +00:00
orikik requested changes 2024-09-27 14:52:05 +00:00
Dismissed
client/pom.xml Outdated
@ -41,0 +42,4 @@
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>simpleclient</artifactId>
<version>0.0.16</version>
orikik commented 2024-09-27 12:30:01 +00:00
Member
Copy link

Why was this particular version of the library chosen? There are also more recent ones.

Why was this particular version of the library chosen? There are also more recent ones.
👍 1
orikik marked this conversation as resolved
pogpp force-pushed feature/16_grpc_interceptors from ff74e5b0a1 to f01c92784d 2024-09-30 10:18:35 +00:00 Compare
pogpp requested review from orikik 2024-09-30 10:18:42 +00:00
orikik approved these changes 2024-09-30 11:48:45 +00:00
pogpp merged commit f01c92784d into master 2024-10-02 08:44:12 +00:00
pogpp deleted branch feature/16_grpc_interceptors 2024-10-02 08:44:17 +00:00
pogpp commented 2024-10-02 08:44:58 +00:00
Author
Member
Copy link

close #16

close #16
Sign in to join this conversation.
Reviewers
No reviewers
orikik
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-java#17
No description provided.
Delete branch "pogpp/frostfs-sdk-java:feature/16_grpc_interceptors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?