[#34] Provide input parameters for all grpc methods #35

orikik · 2025-01-23T12:31:10Z

orikik commented

2025-01-23 12:31:10 +00:00

No description provided.

orikik added 1 commit 2025-01-23 12:31:11 +00:00

[#34 ] Provide input parameters for all grpc methods

DCO / DCO (pull_request) Successful in 25s

Details

Verify code phase / Verify code (pull_request) Successful in 1m37s

Details

52abcc68fc

Signed-off-by: Ori Bruk <o.bruk@yadro.com>

requested reviews from pogpp, PavelGrossSpb

2025-01-23 12:31:26 +00:00

pogpp reviewed 2025-01-23 13:29:29 +00:00

client/src/main/java/info/frostfs/sdk/jdo/parameters/CallContext.java Outdated

					
				@ -0,0 +12,4 @@

				@Getter

				@Builder

				@AllArgsConstructor

				@EqualsAndHashCode

pogpp commented

2025-01-23 13:29:29 +00:00

There are several disadvantages to using Lombok’s @EqualsAndHashCode annotation. First, it can generate unwanted hash code collisions when two objects have different field values but the same hash code.

Second, it may not be compatible with other libraries and frameworks that rely on traditional implementations of equals() and hashCode().

Lastly, it can reduce readability by generating methods that aren’t explicitly defined in the class, making it more difficult to understand the logic of the code.

There are several disadvantages to using Lombok’s @EqualsAndHashCode annotation. First, it can generate unwanted hash code collisions when two objects have different field values but the same hash code. Second, it may not be compatible with other libraries and frameworks that rely on traditional implementations of equals() and hashCode(). Lastly, it can reduce readability by generating methods that aren’t explicitly defined in the class, making it more difficult to understand the logic of the code.

orikik commented

2025-01-23 14:56:28 +00:00

Unfortunately, a collision cannot be avoided in principle, since the hash code is int and due to the birthday problem we only need 77,163 objects before we have a 50/50 chance of hashCode collision(lombok and Objects hashcode realization very similar, just different multiplier). But I agree about the second one, I’ll correct it.

Unfortunately, a collision cannot be avoided in principle, since the hash code is int and due to the [birthday problem](https://en.wikipedia.org/wiki/Birthday_problem) we only need 77,163 objects before we have a 50/50 chance of hashCode collision(lombok and Objects hashcode realization very similar, just different multiplier). But I agree about the second one, I’ll correct it.