TrueCloudLab/frostfs-sdk-java
18
0
Fork 3
Code Issues 4 Pull requests Releases Packages Activity Actions

[#6] cover the models module with junit tests #9

Merged
orikik merged 3 commits from orikik/frostfs-sdk-java:feature/unit-tests-models into master 2024-09-04 19:51:24 +00:00
Conversation 0 Commits 3 Files changed 35 +1264 -37
orikik commented 2024-08-21 08:14:12 +00:00
Member
Copy link
No description provided.
orikik added 2 commits 2024-08-21 08:14:14 +00:00 
Signed-off-by: Ori Bruk <o.bruk@yadro.com>
[#6] cover the models module with junit tests
All checks were successful
DCO / DCO (pull_request) Successful in 28s
Details
441d3129dc 
Signed-off-by: Ori Bruk <o.bruk@yadro.com>
orikik requested review from pogpp 2024-08-21 08:14:21 +00:00
pogpp approved these changes 2024-08-27 14:39:38 +00:00
pogpp reviewed 2024-08-27 14:43:05 +00:00
models/src/main/java/info/frostfs/sdk/mappers/SessionMapper.java Outdated
@ -9,13 +9,14 @@ import java.io.IOException;
import static java.util.Objects.isNull;
public class SessionMapper {
private static final String ERROR_TOKEN_MISSING_ERROR = "Token is not present";
pogpp commented 2024-08-27 14:43:05 +00:00
Member
Copy link

error passed throw the error
error looking to the error
error error error

error passed throw the error error looking to the error error error error
orikik commented 2024-08-27 15:32:58 +00:00
Author
Member
Copy link

My bad, fixed it

My bad, fixed it
orikik added 1 commit 2024-08-27 15:30:55 +00:00
[#6] fix naming
All checks were successful
DCO / DCO (pull_request) Successful in 27s
Details
0d76332f01 
Signed-off-by: Ori Bruk <o.bruk@yadro.com>
orikik merged commit 0d76332f01 into master 2024-08-27 15:34:21 +00:00
orikik deleted branch feature/unit-tests-models 2024-08-27 15:34:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
pogpp
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-java#9
No description provided.
Delete branch "orikik/frostfs-sdk-java:feature/unit-tests-models"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?