TrueCloudLab/frostfs-testcases
25
0
Fork 21
Code Issues 2 Pull requests 2 Releases Activity Actions

Update pilorama loss and shards test cases #177

Merged
ylukoyan merged 1 commit from ylukoyan/frostfs-testcases:pilorama_fix into master 2023-12-22 16:07:26 +00:00
Conversation 0 Commits 1 Files changed 2 +21 -120
ylukoyan commented 2023-12-21 07:46:36 +00:00
Member
Copy link
No description provided.
ylukoyan requested review from qa-committers 2023-12-21 07:56:48 +00:00
ylukoyan requested review from qa-developers 2023-12-21 07:56:52 +00:00
abereziny approved these changes 2023-12-21 08:03:08 +00:00
anikeev-yadro approved these changes 2023-12-22 07:30:00 +00:00
abereziny reviewed 2023-12-22 13:36:49 +00:00
pytest_tests/testsuites/failovers/test_failover_storage.py Outdated
@ -666,2 +655,2 @@
with allure.step("Get list of all pilorama.db"):
piloramas_list_before_removing = self.get_piloramas_list(node_to_check)
piloramas_list_before_removing = []
with allure.step("Get list of all pilorama.db on shards"):
abereziny commented 2023-12-22 13:36:49 +00:00
Member
Copy link

It should be reporter.step everywhere. Looks like branch is not rebased on actual master

It should be `reporter.step` everywhere. Looks like branch is not rebased on actual master
abereziny marked this conversation as resolved
abereziny reviewed 2023-12-22 13:49:01 +00:00
pytest_tests/testsuites/failovers/test_failover_storage.py Outdated
@ -667,1 +655,3 @@
piloramas_list_before_removing = self.get_piloramas_list(node_to_check)
piloramas_list_before_removing = []
with allure.step("Get list of all pilorama.db on shards"):
for shard in node_to_check.shards:
abereziny commented 2023-12-22 13:49:01 +00:00
Member
Copy link

Let's use get_shards directly

Let's use `get_shards` directly
abereziny marked this conversation as resolved
abereziny reviewed 2023-12-22 13:49:20 +00:00
pytest_tests/testsuites/failovers/test_failover_storage.py Outdated
@ -425,3 +425,3 @@
with allure.step("Delete pilorama.db from all nodes"):
for node in self.cluster.storage_nodes:
node.delete_pilorama()
for shard in node.shards:
abereziny commented 2023-12-22 13:49:20 +00:00
Member
Copy link

let's use get_shards directly

let's use `get_shards` directly
abereziny marked this conversation as resolved
ylukoyan force-pushed pilorama_fix from c3f110adb0 to 9e89dba03d 2023-12-22 14:10:49 +00:00 Compare
abereziny approved these changes 2023-12-22 15:34:32 +00:00
anurindm approved these changes 2023-12-22 16:00:07 +00:00
anikeev-yadro approved these changes 2023-12-22 16:02:10 +00:00
ylukoyan merged commit 9e89dba03d into master 2023-12-22 16:07:26 +00:00
ylukoyan deleted branch pilorama_fix 2023-12-22 16:07:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
abereziny
anurindm
anikeev-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#177
No description provided.
Delete branch "ylukoyan/frostfs-testcases:pilorama_fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?