TrueCloudLab/frostfs-testcases

Divide test_expiration_epoch_in_http into several (parametrized) #24

Merged

JuliaKovshova merged 1 commit from EliChin/frostfs-testcases:feature/http_4 into master

2023-04-13 12:25:05 +00:00

EliChin commented

2023-03-20 16:18:50 +00:00

Member

Divide test_expiration_epoch_in_http into 2 tests (parametrized)

Signed-off-by: Liza e.chichindaeva@yadro.com

Divide test_expiration_epoch_in_http into 2 tests (parametrized) Signed-off-by: Liza <e.chichindaeva@yadro.com>

EliChin requested review from JuliaKovshova 2023-03-20 16:19:02 +00:00

abereziny reviewed 2023-03-21 10:07:08 +00:00

pytest_tests/testsuites/services/http_gate/test_http_gate.py Outdated

					
				@ -199,3 +199,4 @@

				        )

				    @pytest.mark.parametrize("epoch_gap", [0, 1])

				    @allure.title("Test Expiration-Epoch in HTTP header")

abereziny commented

2023-03-21 10:06:53 +00:00

Member

It's better to keep allure.title at the top.

It's better to keep allure.title at the top.

pytest_tests/testsuites/services/http_gate/test_http_gate.py Outdated

					
				@ -222,3 +223,2 @@

				            with allure.step("Put objects using HTTP with attribute Expiration-Epoch"):

				                oids.append(

				                    upload_via_http_gate(

				                if get_epoch(self.shell, self.cluster) + 1 <= valid_until:

abereziny commented

2023-03-21 10:04:30 +00:00

Member

Seems that both if and else have the same steps.
So we shouldn't duplicate it :)

Seems that both if and else have the same steps. So we shouldn't duplicate it :)

EliChin commented

2023-04-10 15:14:48 +00:00

Author

Member

Almost. But if adds to the list with oids to stay valid, while else adds to the list of oids to be expired.

Almost. But `if` adds to the list with oids to stay valid, while `else` adds to the list of oids to be expired.

abereziny requested review from qa-committers 2023-03-21 10:07:18 +00:00

abereziny requested review from qa-developers 2023-03-21 10:07:18 +00:00

EliChin force-pushed feature/http_4 from 16eb5e85dd to 184ba91a98

2023-04-10 15:15:46 +00:00

Compare

EliChin force-pushed feature/http_4 from 184ba91a98 to 78172cb999

2023-04-13 06:44:27 +00:00

Compare

EliChin force-pushed feature/http_4 from 78172cb999 to 4838f01393

2023-04-13 10:48:58 +00:00

Compare

EliChin force-pushed feature/http_4 from 4838f01393 to 1e6d3e77f9

2023-04-13 11:20:22 +00:00

Compare

abereziny approved these changes 2023-04-13 11:24:05 +00:00

JuliaKovshova approved these changes 2023-04-13 12:21:49 +00:00

JuliaKovshova merged commit 1e6d3e77f9 into master

2023-04-13 12:25:05 +00:00

Sign in to join this conversation.

No reviewers

TrueCloudLab/qa-developers

No labels

good first issue

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#24

No description provided.