[#278] Add object operation tests with -g flag #278

Merged
abereziny merged 1 commit from Kiriruso/frostfs-testcases:feature/add-object-api-tests-without-user into master 2024-08-05 12:46:23 +00:00
Contributor

The tests check the result of an 'anonymous' user interacting with a gRPC API object.

Signed-off-by: Kirill Sosnovskikh k.sosnovskikh@yadro.com

The tests check the result of an 'anonymous' user interacting with a gRPC API object. Signed-off-by: Kirill Sosnovskikh <k.sosnovskikh@yadro.com>
Kiriruso added 1 commit 2024-07-29 07:37:58 +00:00
[#XX] Add object operation tests with -g flag
Some checks reported warnings
DCO check / Commits Check (pull_request) Has been cancelled
6f569fc757
The tests check the result of an 'anonymous' user interacting with a gRPC API object.

Signed-off-by: Kirill Sosnovskikh <k.sosnovskikh@yadro.com>
Kiriruso changed title from [#XX] Add object operation tests with `-g` flag to [#278] Add object operation tests with `-g` flag 2024-07-29 07:38:05 +00:00
Kiriruso force-pushed feature/add-object-api-tests-without-user from 6f569fc757 to 76d83c7925 2024-07-29 07:38:29 +00:00 Compare
abereziny reviewed 2024-07-29 09:22:44 +00:00
@ -0,0 +35,4 @@
return tombstone.strip()
@pytest.fixture(scope="function")
def public_container(self, default_wallet: WalletInfo) -> Generator[str, None, None]:
Member

Generator[str, None, None]: => str, since fixtures cannot be used directly

`Generator[str, None, None]:` => `str`, since fixtures cannot be used directly
Kiriruso marked this conversation as resolved
abereziny reviewed 2024-07-29 09:23:13 +00:00
@ -0,0 +46,4 @@
yield cid_public
with reporter.step("Delete public container"):
Member

Redundant. We decided to skip cleanups

Redundant. We decided to skip cleanups
Kiriruso marked this conversation as resolved
abereziny reviewed 2024-07-29 09:24:24 +00:00
@ -0,0 +60,4 @@
return FrostfsCli(client_shell, FROSTFS_CLI_EXEC)
@pytest.fixture(scope="function")
def test_file(self) -> TestFile:
Member
instead, use this https://git.frostfs.info/TrueCloudLab/frostfs-testcases/src/branch/master/pytest_tests/testsuites/conftest.py#L163
Kiriruso marked this conversation as resolved
abereziny reviewed 2024-07-29 09:26:08 +00:00
@ -0,0 +64,4 @@
write_object = str(uuid.uuid4())
return TestFile(os.path.join(ASSETS_DIR, write_object))
@allure.title("Get public container")
Member

Make titles richer :)
<Get public container/.../.../> with generated key

Make titles richer :) `<Get public container/.../.../> with generated key`
Author
Contributor

Done, but not sure if it's detailed enough. Give an example if the new option is not suitable.

Done, but not sure if it's detailed enough. Give an example if the new option is not suitable.
abereziny reviewed 2024-07-29 09:26:53 +00:00
@ -0,0 +77,4 @@
with expect_not_raises():
result = frostfs_cli.container.get(rpc_endpoint, cid, generate_key=True, timeout=CLI_DEFAULT_TIMEOUT)
assert result.return_code == 0, result.stderr
Member

looks like redundant check

looks like redundant check
Kiriruso marked this conversation as resolved
abereziny reviewed 2024-07-29 09:27:06 +00:00
abereziny reviewed 2024-07-29 09:31:35 +00:00
@ -0,0 +88,4 @@
rpc_endpoint = self.cluster.default_rpc_endpoint
owner = default_wallet.get_address_from_json(0)
with reporter.step("Get list containers with generate key"):
Member

Get list => List

`Get list` => `List`
Kiriruso marked this conversation as resolved
abereziny reviewed 2024-07-29 09:31:47 +00:00
@ -0,0 +94,4 @@
assert result.return_code == 0, result.stderr
containers = result.stdout.split()
Member

Under the steps please :)

Under the steps please :)
Kiriruso marked this conversation as resolved
Kiriruso changed title from [#278] Add object operation tests with `-g` flag to WIP: [#278] Add object operation tests with `-g` flag 2024-07-29 09:45:38 +00:00
Kiriruso changed title from WIP: [#278] Add object operation tests with `-g` flag to WIP: [#278] Add object operation tests with `-g` flag 2024-07-29 09:45:39 +00:00
Kiriruso changed title from WIP: [#278] Add object operation tests with `-g` flag to [#278] Add object operation tests with `-g` flag 2024-07-29 09:45:57 +00:00
Kiriruso force-pushed feature/add-object-api-tests-without-user from 76d83c7925 to ba90395f99 2024-07-29 12:33:07 +00:00 Compare
d.zayakin referenced this pull request from a commit 2024-07-29 13:59:05 +00:00
d.zayakin approved these changes 2024-07-29 13:59:49 +00:00
Kiriruso force-pushed feature/add-object-api-tests-without-user from ba90395f99 to 626409af78 2024-07-31 07:23:13 +00:00 Compare
abereziny approved these changes 2024-08-05 12:45:25 +00:00
abereziny merged commit 626409af78 into master 2024-08-05 12:46:23 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#278
No description provided.