Added new test cases for s3 gate, delete marker feature #35
No reviewers
Labels
No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-testcases#35
Loading…
Reference in a new issue
No description provided.
Delete branch "ylukoyan/frostfs-testcases:delete_markers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -952,0 +962,4 @@
with allure.step("Delete non-existing object"):
delete_obj = s3_gate_object.delete_object_s3(self.s3_client, bucket, obj_key)
# there should be no objects or delete markers in the bucket
assert "DeleteMarkers" not in delete_obj.keys(), "Delete markers not found"
Error message is misleading. We are expecting Delete markers to not exist, so we shouldn't report it as assertion error message.
"Delete markers should not be created" or smthg
@ -952,0 +986,4 @@
version.get("VersionId") for version in versions if version.get("Key") == file_name
}
assert obj_versions, f"Object versions were not found {objects_list}"
assert "DeleteMarkers" not in delete_object.keys(), "Delete markers not found"
why are we not expecting delete markers here? Also same misleading text.
Nice catch, thanks! Will be fixed
@ -952,0 +996,4 @@
assert (
delete_object.keys() == delete_object_2nd_attempt.keys()
), "Delete markers are not the same"
How can we check delete markers here if we are not expecting it at line 989?
Please squash commits before merge
@ -952,0 +955,4 @@
set_bucket_versioning(self.s3_client, bucket, s3_gate_bucket.VersioningStatus.ENABLED)
objects_list = s3_gate_object.list_objects_versions_s3(self.s3_client, bucket)
assert not objects_list, f"Expected empty bucket, got {objects_list}"
please add allure step descriprion befor this assert.
@ -952,0 +970,4 @@
def test_s3_delete_twice(self, bucket, simple_object_size):
set_bucket_versioning(self.s3_client, bucket, s3_gate_bucket.VersioningStatus.ENABLED)
objects_list = s3_gate_object.list_objects_s3(self.s3_client, bucket)
assert not objects_list, f"Expected empty bucket, got {objects_list}"
please add allure step descriprion befor this assert.
eaa3608d8f
toce3361ce93
ce3361ce93
tocfd567df58
@ -952,0 +961,4 @@
obj_key = "fake_object_key"
with allure.step("Delete non-existing object"):
delete_obj = s3_gate_object.delete_object_s3(self.s3_client, bucket, obj_key)
do we have some error like "this key doesn't exist"?
i think we need additional asseert for this.
@ -952,0 +978,4 @@
file_name = self.object_key_from_file_path(file_path)
with allure.step("Put object into one bucket"):
s3_gate_object.put_object_s3(self.s3_client, bucket, file_path)
please add check for this step.