TrueCloudLab/frostfs-testcases
25
0
Fork 21
Code Issues 2 Pull requests 2 Releases Activity Actions

Add pilorama loss test cases, marked as skipped #45

Merged
ylukoyan merged 1 commit from ylukoyan/frostfs-testcases:tree_loss into master 2023-05-25 08:21:07 +00:00
Conversation 1 Commits 1 Files changed 1 +55
ylukoyan commented 2023-05-22 06:57:57 +00:00
Member
Copy link
No description provided.
JuliaKovshova approved these changes 2023-05-22 07:06:29 +00:00
ylukoyan requested review from qa-committers 2023-05-22 07:46:55 +00:00
ylukoyan requested review from qa-developers 2023-05-22 07:46:55 +00:00
ylukoyan requested review from anikeev-yadro 2023-05-22 07:47:06 +00:00
ylukoyan requested review from abereziny 2023-05-22 07:47:06 +00:00
anikeev-yadro approved these changes 2023-05-22 09:03:09 +00:00
ylukoyan scheduled this pull request to auto merge when all checks succeed 2023-05-23 06:45:25 +00:00
abereziny reviewed 2023-05-23 11:38:12 +00:00
pytest_tests/testsuites/failovers/test_failover_storage.py Outdated
@ -446,2 +446,4 @@
with allure.step("Delete bucket"):
s3_client.delete_bucket(bucket)
@pytest.mark.skip(reason="Need to increase cache lifetime, ticket OBJECT-4176")
abereziny commented 2023-05-23 11:38:12 +00:00
Member
Copy link

Do not include internal information to public repos. (OBJECT-xxx)

Do not include internal information to public repos. (OBJECT-xxx)
👀 1
abereziny marked this conversation as resolved
abereziny reviewed 2023-05-23 11:41:05 +00:00
pytest_tests/testsuites/failovers/test_failover_storage.py Outdated
@ -447,1 +447,4 @@
s3_client.delete_bucket(bucket)
@pytest.mark.skip(reason="Need to increase cache lifetime, ticket OBJECT-4176")
@allure.title("Test S3 Pilorama.db loss, versioning is enabled")
abereziny commented 2023-05-23 11:41:05 +00:00
Member
Copy link

Let's get away from common test titles and be more specific.

@allure.title("After Pilorama.db loss on all nodes list objects should return nothing")

Let's get away from common test titles and be more specific. @allure.title("After Pilorama.db loss on all nodes list objects should return nothing")
👍 1 👀 1
abereziny marked this conversation as resolved
abereziny reviewed 2023-05-23 11:42:00 +00:00
pytest_tests/testsuites/failovers/test_failover_storage.py Outdated
@ -448,0 +490,4 @@
@pytest.mark.skip(reason="Need to increase cache lifetime, ticket OBJECT-4176")
@allure.title("Test S3 Pilorama.db loss, versioning is disabled")
def test_s3_pilorama_loss_versioning_off(self, s3_client: S3ClientWrapper, simple_object_size):
abereziny commented 2023-05-23 11:42:00 +00:00
Member
Copy link

This is a copy-pasta cases with 1 single diff.
Please make it to be one test case with param.

Smth like this

def test_s3_pilorama_loss(self, s3_client: S3ClientWrapper, simple_object_size: int, versioning_status: VersioningStatus):
    <...>
    s3_helper.set_bucket_versioning(s3_client, bucket, versioning_status)
This is a copy-pasta cases with 1 single diff. Please make it to be one test case with param. Smth like this ``` def test_s3_pilorama_loss(self, s3_client: S3ClientWrapper, simple_object_size: int, versioning_status: VersioningStatus): <...> s3_helper.set_bucket_versioning(s3_client, bucket, versioning_status) ```
👀 1
abereziny marked this conversation as resolved
abereziny reviewed 2023-05-23 11:42:31 +00:00
pytest_tests/testsuites/failovers/test_failover_storage.py Outdated
@ -448,0 +448,4 @@
@pytest.mark.skip(reason="Need to increase cache lifetime, ticket OBJECT-4176")
@allure.title("Test S3 Pilorama.db loss, versioning is enabled")
def test_s3_pilorama_loss_versioning_on(self, s3_client: S3ClientWrapper, simple_object_size):
abereziny commented 2023-05-23 11:42:31 +00:00
Member
Copy link

simple_object_size: int

`simple_object_size: int`
👀 1
abereziny marked this conversation as resolved
abereziny requested changes 2023-05-23 12:00:27 +00:00
abereziny left a comment
Member
Copy link

Please consider the above comments

Please consider the above comments
ylukoyan force-pushed tree_loss from e6b1388fb0 to 8d50407439 2023-05-23 14:43:23 +00:00 Compare
ylukoyan requested review from abereziny 2023-05-23 14:43:36 +00:00
abereziny approved these changes 2023-05-23 15:26:28 +00:00
ylukoyan requested review from qa-committers 2023-05-23 18:33:44 +00:00
ylukoyan requested review from qa-developers 2023-05-23 18:33:44 +00:00
ylukoyan requested review from JuliaKovshova 2023-05-24 08:18:04 +00:00
ylukoyan requested review from abereziny 2023-05-24 08:18:08 +00:00
ylukoyan requested review from anikeev-yadro 2023-05-24 08:18:10 +00:00
ylukoyan canceled auto merging this pull request when all checks succeed 2023-05-24 14:38:31 +00:00
abereziny approved these changes 2023-05-24 14:47:25 +00:00
abereziny commented 2023-05-24 14:48:43 +00:00
Member
Copy link

TODO: Add automatic service recovery in case if test fail between service shutdown and service back up. Using cluster_state_controller from Testlib is preferable.

TODO: Add automatic service recovery in case if test fail between service shutdown and service back up. Using cluster_state_controller from Testlib is preferable.
ylukoyan requested review from qa-committers 2023-05-24 14:52:55 +00:00
anikeev-yadro approved these changes 2023-05-24 17:29:30 +00:00
JuliaKovshova approved these changes 2023-05-25 06:37:21 +00:00
ylukoyan merged commit 8d50407439 into master 2023-05-25 08:21:07 +00:00
ylukoyan deleted branch tree_loss 2023-05-25 08:21:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
abereziny
anikeev-yadro
JuliaKovshova
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#45
No description provided.
Delete branch "ylukoyan/frostfs-testcases:tree_loss"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?