TrueCloudLab/frostfs-testcases
23
0
Fork 19
Code Issues 2 Pull requests 2 Releases Activity Actions 1

Add fixture after test #65

Merged
d.zayakin merged 1 commit from d.zayakin/frostfs-testcases:fix-network-test into master 2023-07-13 06:20:11 +00:00
Conversation 0 Commits 1 Files changed 1 +7 -4
d.zayakin commented 2023-07-11 08:54:22 +00:00
Member
Copy link

Signed-off-by: Dmitriy Zayakin d.zayakin@yadro.com

Signed-off-by: Dmitriy Zayakin <d.zayakin@yadro.com>
anikeev-yadro approved these changes 2023-07-11 09:04:44 +00:00
d.zayakin requested review from qa-committers 2023-07-11 09:09:18 +00:00
d.zayakin requested review from qa-developers 2023-07-11 09:09:18 +00:00
abereziny reviewed 2023-07-11 09:41:46 +00:00
pytest_tests/testsuites/failovers/test_failover_network.py Outdated
@ -30,0 +30,4 @@
wakeup_node_timeout = 10
@pytest.fixture()
def blocked_nodes(self):
abereziny commented 2023-07-11 09:41:46 +00:00
Member
Copy link

There are already restore_network bellow

There are already restore_network bellow
abereziny reviewed 2023-07-11 09:42:07 +00:00
pytest_tests/testsuites/failovers/test_failover_network.py Outdated
@ -50,3 +67,2 @@
wallet = default_wallet
placement_rule = "REP 2 IN X CBF 2 SELECT 2 FROM * AS X"
wakeup_node_timeout = 10 # timeout to let nodes detect that traffic has blocked
placement_rule = "REP 2 IN X CBF 2 SELECT 2 FROM * AS X" # timeout to let nodes detect that traffic has blocked
abereziny commented 2023-07-11 09:42:07 +00:00
Member
Copy link

Placement rule is not timeout :)

Placement rule is not timeout :)
abereziny requested changes 2023-07-11 09:43:19 +00:00
abereziny left a comment
Member
Copy link

Not sure why duplicate fixture

Not sure why duplicate fixture
abereziny reviewed 2023-07-11 09:44:24 +00:00
pytest_tests/testsuites/failovers/test_failover_network.py Outdated
@ -46,0 +59,4 @@
default_wallet: str,
require_multiple_hosts,
simple_object_size: int,
blocked_nodes: list,
abereziny commented 2023-07-11 09:44:24 +00:00
Member
Copy link

Also this is never used anywhere

Also this is never used anywhere
JuliaKovshova approved these changes 2023-07-12 07:48:34 +00:00
d.zayakin force-pushed fix-network-test from b4e2c0627a to 3b4c528040 2023-07-12 09:04:35 +00:00 Compare
d.zayakin force-pushed fix-network-test from 3b4c528040 to f4a267fe81 2023-07-12 10:15:13 +00:00 Compare
JuliaKovshova approved these changes 2023-07-12 10:15:55 +00:00
d.zayakin requested review from abereziny 2023-07-12 10:16:11 +00:00
abereziny approved these changes 2023-07-12 14:43:45 +00:00
d.zayakin merged commit f4a267fe81 into master 2023-07-13 06:20:11 +00:00
d.zayakin deleted branch fix-network-test 2023-07-13 06:20:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
anikeev-yadro
JuliaKovshova
abereziny
TrueCloudLab/qa-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#65
No description provided.
Delete branch "d.zayakin/frostfs-testcases:fix-network-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?