New test Split Brain #81

Merged
d.zayakin merged 1 commit from d.zayakin/frostfs-testcases:add-split-brain-test into master 2023-08-16 12:21:54 +00:00
Member

Signed-off-by: Dmitriy Zayakin d.zayakin@yadro.com

Signed-off-by: Dmitriy Zayakin <d.zayakin@yadro.com>
d.zayakin requested review from qa-committers 2023-08-15 11:05:02 +00:00
d.zayakin requested review from qa-developers 2023-08-15 11:05:03 +00:00
d.zayakin force-pushed add-split-brain-test from b1efc0e132 to b8b590f677 2023-08-15 11:29:19 +00:00 Compare
abereziny reviewed 2023-08-15 12:10:24 +00:00
@ -16,6 +16,7 @@ from frostfs_testlib.resources.common import (
DEFAULT_WALLET_PASS,
SIMPLE_OBJECT_SIZE,
)
from frostfs_testlib.s3 import AwsCliClient
Member

What for?

What for?
Author
Member

delete import

delete import
abereziny marked this conversation as resolved
d.zayakin force-pushed add-split-brain-test from b8b590f677 to 8470cf4e12 2023-08-15 13:01:51 +00:00 Compare
d.zayakin force-pushed add-split-brain-test from 8470cf4e12 to 5ddd6148e4 2023-08-15 13:10:05 +00:00 Compare
d.zayakin force-pushed add-split-brain-test from 5ddd6148e4 to 9dbbda3ca1 2023-08-15 13:48:14 +00:00 Compare
d.zayakin force-pushed add-split-brain-test from 9dbbda3ca1 to ff1f176642 2023-08-15 14:08:58 +00:00 Compare
abereziny approved these changes 2023-08-15 14:16:31 +00:00
ylukoyan reviewed 2023-08-16 08:39:47 +00:00
@ -120,0 +168,4 @@
if matches:
return matches[0]
else:
return logger.info(f"Key {pattern} no search")
Member

Может стоит дропать эксепшн здесь? Внизу ты используешь функцию так, как будто бакет всегда находится, но тут есть ветвление

Может стоит дропать эксепшн здесь? Внизу ты используешь функцию так, как будто бакет всегда находится, но тут есть ветвление
Author
Member

done

done
@ -120,0 +377,4 @@
)
with allure.step(f"Checking ping from {node} to {segment_two}, expected False"):
assert (
cluster_state_controller.ping_traffic(node, segment_two, 1) is True
Member

Но ты проверяешь здесь на is True, а по комментарию ожидаешь False?

Но ты проверяешь здесь на is True, а по комментарию ожидаешь False?
Author
Member

done

done
@ -120,0 +413,4 @@
for node in segment_two:
with allure.step(f"Checking ping from {node} to {segment_one}, expected True"):
assert cluster_state_controller.ping_traffic(
node, segment_one, 0
Member

А здесь вызываешь ту же функцию cluster_state_controller.ping_traffic, но не указываешь явно ожидаемый статус (is True / is False)

А здесь вызываешь ту же функцию cluster_state_controller.ping_traffic, но не указываешь явно ожидаемый статус (is True / is False)
Author
Member

done

done
d.zayakin force-pushed add-split-brain-test from ff1f176642 to e70532d6e0 2023-08-16 08:54:06 +00:00 Compare
abereziny approved these changes 2023-08-16 09:33:26 +00:00
ylukoyan approved these changes 2023-08-16 12:11:15 +00:00
d.zayakin merged commit e70532d6e0 into master 2023-08-16 12:21:54 +00:00
d.zayakin deleted branch add-split-brain-test 2023-08-16 12:21:55 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#81
No description provided.