New fixture for s3 client init #91

d.zayakin · 2023-09-14T04:48:37Z

d.zayakin commented

2023-09-14 04:48:37 +00:00

Signed-off-by: Dmitriy Zayakin d.zayakin@yadro.com

Signed-off-by: Dmitriy Zayakin <d.zayakin@yadro.com>

requested reviews from qa-committers, qa-developers

2023-09-14 04:49:02 +00:00

d.zayakin force-pushed change-split-brain from db62357be2 to edeeba5205

2023-09-14 04:50:09 +00:00

Compare

d.zayakin changed title from ~~Add new argument for init s3 function~~ to New fixture for s3 client init

2023-09-14 04:50:42 +00:00

JuliaKovshova approved these changes 2023-09-14 07:35:37 +00:00

ylukoyan approved these changes 2023-09-14 09:00:20 +00:00

d.zayakin force-pushed change-split-brain from edeeba5205 to 8a6c9f158c

2023-09-18 10:32:59 +00:00

Compare

abereziny reviewed 2023-09-18 10:57:17 +00:00

pytest_tests/testsuites/failovers/test_failover_network.py Outdated

					
				@ -41,1 +42,3 @@

				        metafunc.parametrize("s3_client", [AwsCliClient], ids=["aws"], indirect=True)

				        metafunc.parametrize(

				            "s3_client, container_placement_policy",

				            [(AwsCliClient, "")],

abereziny commented

2023-09-18 10:57:14 +00:00

What is the actual intention here?
If we don't use the container_placement_policy we can skip mentioning it.

Edit:
I've got it...

Change this

[(AwsCliClient, "")],

to

[(AwsCliClient, "REP $REP_NODE_COUNT$")],

What is the actual intention here? If we don't use the `container_placement_policy` we can skip mentioning it. Edit: I've got it... Change this ``` [(AwsCliClient, "")], ``` to ``` [(AwsCliClient, "REP $REP_NODE_COUNT$")], ```

d.zayakin commented

2023-09-18 17:26:38 +00:00

done

abereziny marked this conversation as resolved

pytest_tests/testsuites/failovers/test_failover_network.py

					
				@ -297,7 +305,7 @@ class TestFailoverSplitBrain(ClusterTestBase):

				        with allure.step("Tick 1 epoch and wait 2 block"):

abereziny commented

2023-09-18 10:51:31 +00:00

So wait for 10 blocks now?

d.zayakin commented

2023-09-18 17:26:52 +00:00

done

abereziny marked this conversation as resolved

abereziny reviewed 2023-09-18 11:06:04 +00:00

pytest_tests/testsuites/conftest.py Outdated

					
				@ -276,0 +284,4 @@

				    cluster: Cluster, default_wallet: str, request: pytest.FixtureRequest

				):

				    container_placement_policy = None

				    if "param" in request.__dict__:

abereziny commented

2023-09-18 11:06:04 +00:00

placeholders = {
   "$REP_NODE_COUNT$": 4 if len(cluster.cluster_nodes) < 8 else 8,
   "$NODE_COUNT$": len(cluster.cluster_nodes)
}

if "param" in request.__dict__:
   for key, value in placeholders.items():
         container_placement_policy = container_placement_policy.replace(key, value)

``` placeholders = { "$REP_NODE_COUNT$": 4 if len(cluster.cluster_nodes) < 8 else 8, "$NODE_COUNT$": len(cluster.cluster_nodes) } if "param" in request.__dict__: for key, value in placeholders.items(): container_placement_policy = container_placement_policy.replace(key, value) ```

d.zayakin commented

2023-09-18 17:26:45 +00:00

done

abereziny marked this conversation as resolved

d.zayakin force-pushed change-split-brain from 8a6c9f158c to 9776cb383c

2023-09-18 17:15:41 +00:00

Compare

d.zayakin force-pushed change-split-brain from 9776cb383c to d0d5bf24ba

2023-09-18 17:19:48 +00:00

Compare

d.zayakin force-pushed change-split-brain from d0d5bf24ba to 6310ab0862

2023-09-18 18:01:18 +00:00