Refactoring old functions for FrostfsCli #145

Closed
mkadilov wants to merge 3 commits from (deleted):bug/cli_methods_moving into master
Member

Refactoring old functions for FrostfsCli

Refactoring old functions for FrostfsCli
Member

Can't understand the sense of the refactoring. Please elaborate

Can't understand the sense of the refactoring. Please elaborate
mkadilov force-pushed bug/cli_methods_moving from 03880da588 to 47487cbecb 2023-12-14 10:37:57 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 47487cbecb to cefe4629d8 2023-12-15 11:34:43 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from cefe4629d8 to 37d4622642 2023-12-15 11:53:40 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 37d4622642 to 6b7a4746e9 2023-12-15 12:30:49 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 6b7a4746e9 to 8148c1275d 2023-12-15 12:34:16 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 8148c1275d to 174086e90c 2023-12-15 12:45:36 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 174086e90c to f1bd824f89 2023-12-15 13:10:30 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from f1bd824f89 to a22d71c862 2023-12-15 13:11:38 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from a22d71c862 to 593bbe9988 2023-12-15 14:05:56 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from f480dfe7e9 to bedc9cfd7b 2023-12-20 14:18:02 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 67b9d9d4df to f50df1dd39 2024-02-05 12:38:13 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from f50df1dd39 to 9bd19fbb55 2024-02-05 13:01:24 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 55206d29b1 to d5bd39d7f3 2024-02-09 10:09:22 +00:00 Compare
Author
Member
Related changes: https://git.frostfs.info/TrueCloudLab/frostfs-testcases/pulls/193/
mkadilov requested review from abereziny 2024-02-14 14:43:19 +00:00
mkadilov requested review from d.zayakin 2024-02-14 14:43:35 +00:00
abereziny requested changes 2024-02-14 21:20:43 +00:00
abereziny left a comment
Member

Looks like total mess, I can't understand the point of any of that

Looks like total mess, I can't understand the point of any of that
@ -11,3 +11,3 @@
wallet: str,
wallet_password: str,
id: Optional[list[str]],
id_: Optional[list[str]],
Member

and this?

and this?
@ -14,2 +13,3 @@
id_: Optional[list[str]],
address: Optional[str] = None,
all: bool = False,
all_: bool = False,
Member

why this was changed ?

why this was changed ?
@ -32,1 +32,4 @@
"""
args_dict = locals()
if id_ != None:
args_dict["id_"] = args_dict.pop('id')
Member

????

????
@ -111,4 +109,2 @@
)
return shards_cli.set_mode(
self.storage_node.get_control_endpoint(),
self.storage_node.get_remote_wallet_path(),
Member

why?

why?
@ -98,4 +98,2 @@
response = shards_cli.list(
endpoint=self.storage_node.get_control_endpoint(),
wallet=self.storage_node.get_remote_wallet_path(),
wallet_password=self.storage_node.get_wallet_password(),
Member

also why?

also why?
mkadilov force-pushed bug/cli_methods_moving from 0a86379a99 to 0847bb4391 2024-02-16 11:30:52 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 0847bb4391 to f30905e594 2024-02-16 11:57:48 +00:00 Compare
mkadilov added 1 commit 2024-02-16 15:35:55 +00:00
FrostfaCli methods moved to FrostfsCliControl

Signed-off-by: Mikhail Kadilov m.kadilov@yadro.com
mkadilov added 1 commit 2024-02-16 17:27:54 +00:00
FrostfaCli methods moved to FrostfsCliControl

Signed-off-by: Mikhail Kadilov m.kadilov@yadro.com
mkadilov closed this pull request 2024-02-19 08:53:32 +00:00

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testlib#145
No description provided.