TrueCloudLab/frostfs-testlib
25
0
Fork 19
Code Issues Pull requests 3 Releases 1 Activity Actions 4

Refactoring old functions for FrostfsCli #145

Closed
mkadilov wants to merge 3 commits from (deleted):bug/cli_methods_moving into master
pull from: (deleted):bug/cli_methods_moving
merge into: TrueCloudLab:master
Conversation 2 Commits 3 Files changed 4 +108 -62
mkadilov commented 2023-12-13 09:42:53 +00:00
Member
Copy link

Refactoring old functions for FrostfsCli

Refactoring old functions for FrostfsCli
abereziny commented 2023-12-13 09:56:43 +00:00
Member
Copy link

Can't understand the sense of the refactoring. Please elaborate

Can't understand the sense of the refactoring. Please elaborate
mkadilov force-pushed bug/cli_methods_moving from 03880da588 to 47487cbecb 2023-12-14 10:37:57 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 47487cbecb to cefe4629d8 2023-12-15 11:34:43 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from cefe4629d8 to 37d4622642 2023-12-15 11:53:40 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 37d4622642 to 6b7a4746e9 2023-12-15 12:30:49 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 6b7a4746e9 to 8148c1275d 2023-12-15 12:34:16 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 8148c1275d to 174086e90c 2023-12-15 12:45:36 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 174086e90c to f1bd824f89 2023-12-15 13:10:30 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from f1bd824f89 to a22d71c862 2023-12-15 13:11:38 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from a22d71c862 to 593bbe9988 2023-12-15 14:05:56 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from f480dfe7e9 to bedc9cfd7b 2023-12-20 14:18:02 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 67b9d9d4df to f50df1dd39 2024-02-05 12:38:13 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from f50df1dd39 to 9bd19fbb55 2024-02-05 13:01:24 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 55206d29b1 to d5bd39d7f3 2024-02-09 10:09:22 +00:00 Compare
mkadilov commented 2024-02-09 10:43:50 +00:00
Author
Member
Copy link

Related changes:
TrueCloudLab/frostfs-testcases#193/

Related changes: https://git.frostfs.info/TrueCloudLab/frostfs-testcases/pulls/193/
mkadilov requested review from abereziny 2024-02-14 14:43:19 +00:00
mkadilov requested review from d.zayakin 2024-02-14 14:43:35 +00:00
abereziny requested changes 2024-02-14 21:20:43 +00:00
abereziny left a comment
Member
Copy link

Looks like total mess, I can't understand the point of any of that

Looks like total mess, I can't understand the point of any of that
src/frostfs_testlib/cli/frostfs_cli/shards.py Outdated
@ -11,3 +11,3 @@
wallet: str,
wallet_password: str,
id: Optional[list[str]],
id_: Optional[list[str]],
abereziny commented 2023-12-18 08:20:23 +00:00
Member
Copy link

and this?

and this?
src/frostfs_testlib/cli/frostfs_cli/shards.py Outdated
@ -14,2 +13,3 @@
id_: Optional[list[str]],
address: Optional[str] = None,
all: bool = False,
all_: bool = False,
abereziny commented 2023-12-18 08:20:11 +00:00
Member
Copy link

why this was changed ?

why this was changed ?
src/frostfs_testlib/cli/frostfs_cli/shards.py Outdated
@ -32,1 +32,4 @@
"""
args_dict = locals()
if id_ != None:
args_dict["id_"] = args_dict.pop('id')
abereziny commented 2023-12-18 08:20:39 +00:00
Member
Copy link

????

????
src/frostfs_testlib/storage/controllers/shards_watcher.py Outdated
@ -111,4 +109,2 @@
)
return shards_cli.set_mode(
self.storage_node.get_control_endpoint(),
self.storage_node.get_remote_wallet_path(),
abereziny commented 2023-12-18 08:21:42 +00:00
Member
Copy link

why?

why?
src/frostfs_testlib/storage/controllers/shards_watcher.py Outdated
@ -98,4 +98,2 @@
response = shards_cli.list(
endpoint=self.storage_node.get_control_endpoint(),
wallet=self.storage_node.get_remote_wallet_path(),
wallet_password=self.storage_node.get_wallet_password(),
abereziny commented 2023-12-18 08:21:49 +00:00
Member
Copy link

also why?

also why?
mkadilov force-pushed bug/cli_methods_moving from 0a86379a99 to 0847bb4391 2024-02-16 11:30:52 +00:00 Compare
mkadilov force-pushed bug/cli_methods_moving from 0847bb4391 to f30905e594 2024-02-16 11:57:48 +00:00 Compare
mkadilov added 1 commit 2024-02-16 15:35:55 +00:00 
FrostfaCli methods moved to FrostfsCliControl

Signed-off-by: Mikhail Kadilov m.kadilov@yadro.com
mkadilov added 1 commit 2024-02-16 17:27:54 +00:00 
FrostfaCli methods moved to FrostfsCliControl

Signed-off-by: Mikhail Kadilov m.kadilov@yadro.com
mkadilov closed this pull request 2024-02-19 08:53:32 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
abereziny
d.zayakin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testlib#145
No description provided.
Delete branch "(deleted):bug/cli_methods_moving"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?