TrueCloudLab/frostfs-testlib
23
0
Fork 18
Code Issues Pull requests 4 Releases 1 Activity Actions

[#213] Return response in complete_multipart_upload function #213

Merged
ylukoyan merged 1 commit from ylukoyan/frostfs-testlib:037 into support/v0.37 2024-04-25 12:59:01 +00:00
Conversation 0 Commits 1 Files changed 2 +6 -1
ylukoyan commented 2024-04-23 21:00:57 +00:00
Member
Copy link
No description provided.
ylukoyan requested review from qa-committers 2024-04-23 21:01:09 +00:00
ylukoyan requested review from qa-developers 2024-04-23 21:01:09 +00:00
anikeev-yadro approved these changes 2024-04-24 05:26:22 +00:00
abereziny approved these changes 2024-04-24 10:51:27 +00:00
abereziny reviewed 2024-04-24 10:53:18 +00:00
src/frostfs_testlib/s3/aws_cli_client.py
@ -697,2 +697,4 @@
response = self._to_json(output)
return response
@reporter.step_deco("Put object lock configuration")
abereziny commented 2024-04-24 10:53:18 +00:00
Member
Copy link

need empty line between methods

need empty line between methods
abereziny marked this conversation as resolved
abereziny reviewed 2024-04-24 10:53:23 +00:00
src/frostfs_testlib/s3/boto3_client.py Outdated
@ -573,6 +573,7 @@ class Boto3ClientWrapper(S3ClientWrapper):
)
log_command_execution("S3 Complete multipart upload", response)
return response
abereziny commented 2024-04-24 10:53:23 +00:00
Member
Copy link

need empty line between methods

need empty line between methods
ylukoyan force-pushed 037 from 47b328123f to 8f7f222e0d 2024-04-24 11:55:47 +00:00 Compare
anikeev-yadro approved these changes 2024-04-24 12:05:24 +00:00
abereziny approved these changes 2024-04-24 12:06:06 +00:00
ylukoyan merged commit 8f7f222e0d into support/v0.37 2024-04-25 12:59:01 +00:00
ylukoyan deleted branch 037 2024-04-25 12:59:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
anikeev-yadro
abereziny
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testlib#213
No description provided.
Delete branch "ylukoyan/frostfs-testlib:037"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?