TrueCloudLab/frostfs-testlib
25
0
Fork 20
Code Issues Pull requests 1 Releases 1 Activity Actions

[#326] Automation of PATCH method in GRPC #326

Merged
abereziny merged 1 commit from Kiriruso/frostfs-testlib:feature-patch-testsuite-part-one into master 2024-12-05 10:28:07 +00:00
Conversation 0 Commits 1 Files changed 5 +165
Kiriruso commented 2024-11-26 16:02:15 +00:00
Contributor
Copy link

Signed-off-by: Kirill Sosnovskikh k.sosnovskikh@yadro.com

Signed-off-by: Kirill Sosnovskikh <k.sosnovskikh@yadro.com>
Kiriruso added 1 commit 2024-11-26 16:02:15 +00:00
[#326] Automation of PATCH in GRPC
Some checks failed
DCO action / DCO (pull_request) Has been cancelled
Details
7e0eefcba8 
Signed-off-by: Kirill Sosnovskikh <k.sosnovskikh@yadro.com>
requested reviews from JuliaKovshova, abereziny, d.zayakin, anikeev-yadro, anurindm, ylukoyan, i.niyazov 2024-11-26 16:02:15 +00:00
Kiriruso force-pushed feature-patch-testsuite-part-one from 7e0eefcba8 to 6200577af5 2024-11-26 16:27:38 +00:00 Compare
Kiriruso changed title from [#326] Automation of PATCH in GRPC to [#326] Automation of PATCH method in GRPC 2024-11-26 16:27:48 +00:00
i.niyazov reviewed 2024-11-27 06:47:23 +00:00
src/frostfs_testlib/steps/cli/object.py Outdated
@ -284,2 +284,4 @@
@reporter.step("Patch object {cid}/{oid} from {endpoint}")
def patch_object(
i.niyazov commented 2024-11-27 06:47:23 +00:00
Member
Copy link

why did you add patch method to folder steps?
I think it is enough to use this method via FrostfsCli implementations

why did you add patch method to folder steps? I think it is enough to use this method via FrostfsCli implementations
Kiriruso commented 2024-11-27 13:27:25 +00:00
Author
Contributor
Copy link

Added based on the surrounding code, in principle, this function is not required to test the functionality. I can remove this.

Added based on the surrounding code, in principle, this function is not required to test the functionality. I can remove this.
i.niyazov commented 2024-11-28 08:15:55 +00:00
Member
Copy link

please remove it, we try to use in everywhere CliClientWrapper for frostfs-cli operations

please remove it, we try to use in everywhere `CliClientWrapper` for frostfs-cli operations
Kiriruso marked this conversation as resolved
Kiriruso force-pushed feature-patch-testsuite-part-one from 6200577af5 to c47e0ea7d0 2024-11-28 08:35:16 +00:00 Compare
abereziny approved these changes 2024-11-28 12:50:07 +00:00
Dismissed
requested reviews from qa-committers and removed review requests for JuliaKovshova, d.zayakin, anikeev-yadro, anurindm, ylukoyan, i.niyazov 2024-11-28 12:54:23 +00:00
Kiriruso force-pushed feature-patch-testsuite-part-one from c47e0ea7d0 to 1e8e983d05 2024-12-03 00:27:32 +00:00 Compare
Kiriruso dismissed abereziny's review 2024-12-03 00:27:32 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

d.zayakin approved these changes 2024-12-03 08:47:32 +00:00
abereziny approved these changes 2024-12-04 10:55:41 +00:00
abereziny merged commit b3d05c5c28 into master 2024-12-05 10:28:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
d.zayakin
abereziny
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testlib#326
No description provided.
Delete branch "Kiriruso/frostfs-testlib:feature-patch-testsuite-part-one"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?