Change CSC time methods #355

d.zayakin · 2025-02-04T06:57:54Z

d.zayakin commented

2025-02-04 06:57:54 +00:00

Signed-off-by: Dmitriy Zayakin d.zayakin@yadro.com

Signed-off-by: Dmitriy Zayakin <d.zayakin@yadro.com>

d.zayakin added 1 commit 2025-02-04 06:57:54 +00:00

[#355 ] Change CSC time methods

DCO action / DCO (pull_request) Successful in 28s

Details

b41e197ec2

Signed-off-by: Dmitriy Zayakin <d.zayakin@yadro.com>

requested review from qa-committers

2025-02-04 06:57:55 +00:00

Kiriruso reviewed 2025-02-04 12:30:36 +00:00

src/frostfs_testlib/storage/controllers/cluster_state_controller.py Outdated

					
				@ -392,2 +391,3 @@

				    def get_node_date(self, node: ClusterNode) -> datetime.datetime:

				        shell = node.host.get_shell()

				        return datetime.datetime.strptime(shell.exec("hwclock -r").stdout.strip(), "%Y-%m-%d %H:%M:%S.%f%z")

				        return datetime.datetime.strptime(shell.exec('date +"%Y-%m-%d %H:%M:%S"').stdout.strip(), "%Y-%m-%d %H:%M:%S")

Kiriruso commented

2025-02-04 12:30:36 +00:00

Duplicating datetime.datetime looks bad, what about importing datetime.datetime and datetime.timezone separately?

-> from datetime import datetime, timezone

Duplicating `datetime.datetime` looks bad, what about importing `datetime.datetime` and `datetime.timezone` separately? -> `from datetime import datetime, timezone`

👍 1

d.zayakin commented

2025-02-04 13:40:06 +00:00

Done

d.zayakin marked this conversation as resolved

d.zayakin force-pushed csc-time-methods from b41e197ec2 to 2ffb80bbf4

2025-02-04 13:39:55 +00:00

Compare

anurindm approved these changes 2025-02-05 11:34:15 +00:00

abereziny approved these changes 2025-02-05 11:45:38 +00:00

d.zayakin merged commit e9bc36b3d3 into master

2025-02-05 11:47:09 +00:00