TrueCloudLab/frostfs-testlib
25
0
Fork 20
Code Issues Pull requests 1 Releases 1 Activity Actions

Add morph remove node command #14

Merged
anikeev-yadro merged 1 commit from anikeev-yadro/frostfs-testlib:anikeev/add_morph_remove_node into master 2023-03-16 14:43:03 +00:00
Conversation 0 Commits 1 Files changed 1 +28 -2
anikeev-yadro commented 2023-03-14 12:09:06 +00:00
Member
Copy link

Add new comnand to remove node from netwok map

Signed-off-by: anikeev-yadro a.anikeev@yadro.com

Add new comnand to remove node from netwok map Signed-off-by: anikeev-yadro <a.anikeev@yadro.com>
JuliaKovshova was assigned by anikeev-yadro 2023-03-14 12:09:06 +00:00
abereziny was assigned by anikeev-yadro 2023-03-14 12:09:06 +00:00
requested reviews from JuliaKovshova, abereziny 2023-03-15 06:22:13 +00:00
JuliaKovshova was unassigned by anikeev-yadro 2023-03-15 06:22:22 +00:00
abereziny was unassigned by anikeev-yadro 2023-03-15 06:22:23 +00:00
anikeev-yadro force-pushed anikeev/add_morph_remove_node from 69ffed53bf to d2e1c56ed4 2023-03-15 06:23:55 +00:00 Compare
abereziny reviewed 2023-03-15 08:13:48 +00:00
src/frostfs_testlib/cli/frostfs_adm/morph.py Outdated
@ -356,1 +356,4 @@
)
def remove_node(
self, node_netmap_key: str, rpc_endpoint: Optional[str] = None, alphabet: Optional[str] = None
abereziny commented 2023-03-15 08:13:42 +00:00
Member
Copy link

The parameter alphabet should be renamed to alphabet_wallets

> neofs-adm morph remove-nodes --help
Move nodes to the Offline state in the candidates list and tick an epoch to update the netmap

Usage:
  neofs-adm morph remove-nodes key1 [key2 [...]] [flags]

Flags:
      --alphabet-wallets string   Path to alphabet wallets dir
  -h, --help                      help for remove-nodes
  -r, --rpc-endpoint string       N3 RPC node endpoint
The parameter `alphabet` should be renamed to `alphabet_wallets` ``` > neofs-adm morph remove-nodes --help Move nodes to the Offline state in the candidates list and tick an epoch to update the netmap Usage: neofs-adm morph remove-nodes key1 [key2 [...]] [flags] Flags: --alphabet-wallets string Path to alphabet wallets dir -h, --help help for remove-nodes -r, --rpc-endpoint string N3 RPC node endpoint ```
anikeev-yadro commented 2023-03-15 15:57:30 +00:00
Author
Member
Copy link

fixed

fixed
anikeev-yadro marked this conversation as resolved
fyrchik reviewed 2023-03-15 08:46:00 +00:00
src/frostfs_testlib/cli/frostfs_adm/morph.py Outdated
@ -357,0 +370,4 @@
Command's result.
"""
return self._execute(
f"morph remove-nodes '{node_netmap_key}'",
fyrchik commented 2023-03-15 08:46:00 +00:00
Owner
Copy link

neofs-adm supports removing multiple nodes in one command, maybe reflect this in the function interface?

neofs-adm supports removing multiple nodes in one command, maybe reflect this in the function interface?
anikeev-yadro commented 2023-03-15 15:57:18 +00:00
Author
Member
Copy link

fixed

fixed
anikeev-yadro marked this conversation as resolved
anikeev-yadro force-pushed anikeev/add_morph_remove_node from d2e1c56ed4 to 539d4c29e6 2023-03-15 15:56:45 +00:00 Compare
anikeev-yadro force-pushed anikeev/add_morph_remove_node from 539d4c29e6 to e73585cf50 2023-03-15 16:20:13 +00:00 Compare
requested review from fyrchik 2023-03-15 16:20:57 +00:00
abereziny approved these changes 2023-03-16 08:12:02 +00:00
JuliaKovshova approved these changes 2023-03-16 09:17:12 +00:00
fyrchik approved these changes 2023-03-16 13:44:27 +00:00
anikeev-yadro merged commit e73585cf50 into master 2023-03-16 14:43:03 +00:00
anikeev-yadro deleted branch anikeev/add_morph_remove_node 2023-03-16 14:43:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
abereziny
JuliaKovshova
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testlib#14
No description provided.
Delete branch "anikeev-yadro/frostfs-testlib:anikeev/add_morph_remove_node"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?