TrueCloudLab
/
frostfs-testlib
22
0
Fork 15
Code Issues Pull Requests 1 Actions Releases 1 Activity

Move shared code to testlib #17

Merged
abereziny merged 1 commits from abereziny/frostfs-testlib:feature-move-shared-codebase into master 2023-05-15 11:12:58 +00:00
Conversation 0 Commits 1 Files Changed 69
abereziny commented 2023-05-14 10:46:18 +00:00
Collaborator
  • Move shared code from testcases to testlib.
  • Remove 3rd party company notes
  • update version to 2.0.0

Signed-off-by: Andrey Berezin a.berezin@yadro.com

+ Move shared code from testcases to testlib. + Remove 3rd party company notes + update version to 2.0.0 Signed-off-by: Andrey Berezin <a.berezin@yadro.com>
abereziny added 1 commit 2023-05-14 10:46:19 +00:00
997e768e92 Move shared code to testlib 
Signed-off-by: Andrey Berezin <a.berezin@yadro.com>
abereziny requested review from qa-committers 2023-05-14 10:46:26 +00:00
abereziny requested review from qa-developers 2023-05-14 10:46:26 +00:00
abereziny added the
P0
refactoring
 labels 2023-05-14 10:47:15 +00:00
anikeev-yadro approved these changes 2023-05-14 14:04:18 +00:00
JuliaKovshova approved these changes 2023-05-15 06:29:42 +00:00
src/frostfs_testlib/cli/frostfs_adm/adm.py
@ -12,4 +12,0 @@
morph: Optional[FrostfsAdmMorph] = None
subnet: Optional[FrostfsAdmMorphSubnet] = None
storage_config: Optional[FrostfsAdmStorageConfig] = None
version: Optional[FrostfsAdmVersion] = None
JuliaKovshova commented 2023-05-15 06:29:34 +00:00
Collaborator

are you sure that removing default values is a good idea?

are you sure that removing default values is a good idea?
abereziny commented 2023-05-15 07:56:55 +00:00
Poster
Collaborator

Yes, since it's not a dataclass. And these variables filled on __init__

Yes, since it's not a dataclass. And these variables filled on `__init__`
src/frostfs_testlib/cli/frostfs_adm/adm.py
@ -16,0 +13,4 @@
subnet: FrostfsAdmMorphSubnet
storage_config: FrostfsAdmStorageConfig
version: FrostfsAdmVersion
config: FrostfsAdmConfig
JuliaKovshova commented 2023-05-15 06:28:11 +00:00
Collaborator

why you add config and don't use it?

why you add config and don't use it?
abereziny commented 2023-05-15 07:57:38 +00:00
Poster
Collaborator

It was missing before. I just added missing var )

It was missing before. I just added missing var )
src/frostfs_testlib/controllers/cluster_state_controller.py
@ -0,0 +19,4 @@
reporter = get_reporter()
class ClusterStateController:
JuliaKovshova commented 2023-05-15 06:18:33 +00:00
Collaborator

is this initialization only once at test/suite/run?

is this initialization only once at test/suite/run?
abereziny commented 2023-05-15 07:58:28 +00:00
Poster
Collaborator

Depends on usage. But ideally it should be provided by "session" fixture

Depends on usage. But ideally it should be provided by "session" fixture
abereziny requested review from qa-developers 2023-05-15 08:03:03 +00:00
yadro-vavdeev requested review from yadro-vavdeev 2023-05-15 08:14:06 +00:00
yadro-vavdeev refused to review 2023-05-15 08:20:14 +00:00
yadro-vavdeev requested review from yadro-vavdeev 2023-05-15 08:20:37 +00:00
yadro-vavdeev refused to review 2023-05-15 08:22:26 +00:00
abereziny requested review from qa-committers 2023-05-15 08:24:16 +00:00
yadro-vavdeev approved these changes 2023-05-15 08:26:06 +00:00
abereziny merged commit 997e768e92 into master 2023-05-15 11:12:58 +00:00
abereziny deleted branch feature-move-shared-codebase 2023-05-15 11:12:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
anikeev-yadro
JuliaKovshova
yadro-vavdeev
TrueCloudLab/qa-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testlib#17
There is no content yet.
Delete Branch "abereziny/frostfs-testlib:feature-move-shared-codebase"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?