TrueCloudLab/frostfs-testlib
25
0
Fork 19
Code Issues Pull requests 2 Releases 1 Activity Actions 4

[#213] Return response in complete_multipart_upload function #213

Merged
ylukoyan merged 1 commit from ylukoyan/frostfs-testlib:037 into support/v0.37 2024-04-25 12:59:01 +00:00
Conversation 0 Commits 1 Files changed 2 +6 -1
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/frostfs_testlib/s3/aws_cli_client.py
View file

@ -693,7 +693,10 @@ class AwsCliClient(S3ClientWrapper):
f"--key {key} --upload-id {upload_id} --multipart-upload file://{file_path} " f"--key {key} --upload-id {upload_id} --multipart-upload file://{file_path} "
f"--endpoint-url {self.s3gate_endpoint}" f"--endpoint-url {self.s3gate_endpoint}"
) )
self.local_shell.exec(cmd) output = self.local_shell.exec(cmd).stdout
response = self._to_json(output)
return response
abereziny marked this conversation as resolved
abereziny commented 2024-04-24 10:53:18 +00:00
Review
Copy link

need empty line between methods

need empty line between methods
@reporter.step_deco("Put object lock configuration") @reporter.step_deco("Put object lock configuration")
def put_object_lock_configuration(self, bucket: str, configuration: dict) -> dict: def put_object_lock_configuration(self, bucket: str, configuration: dict) -> dict:

2
src/frostfs_testlib/s3/boto3_client.py
View file

@ -573,6 +573,8 @@ class Boto3ClientWrapper(S3ClientWrapper):
) )
log_command_execution("S3 Complete multipart upload", response) log_command_execution("S3 Complete multipart upload", response)
return response
abereziny commented 2024-04-24 10:53:23 +00:00
Outdated
Review
Copy link

need empty line between methods

need empty line between methods
@reporter.step_deco("Put object retention") @reporter.step_deco("Put object retention")
@report_error @report_error
def put_object_retention( def put_object_retention(