Added wait_for_node_to_be_ready to starting stopped storage nodes #29

ylukoyan · 2023-05-26T07:21:33Z

ylukoyan commented

2023-05-26 07:21:33 +00:00

No description provided.

abereziny requested changes 2023-05-26 08:26:39 +00:00

src/frostfs_testlib/storage/controllers/cluster_state_controller.py Outdated

					
				@ -90,6 +91,7 @@ class ClusterStateController:

				    def start_stopped_storage_services(self):

				        for node in self.stopped_storage_nodes:

				            node.start_service()

				            wait_for_node_to_be_ready(node)

abereziny commented

2023-05-26 08:26:36 +00:00

This is potentially bad change.
Let say you have 4 services turned off.

You start first one and wait for READY status.
Since other 3 services are still down - this one will also never be ready.

If you want to wait for it to be ready, you should use
wait_all_storage_nodes_returned(self.shell, self.cluster)
after all services were started.

This is potentially bad change. Let say you have 4 services turned off. You start first one and wait for READY status. Since other 3 services are still down - this one will also never be ready. If you want to wait for it to be ready, you should use `wait_all_storage_nodes_returned(self.shell, self.cluster)` after all services were started.

👀 1

abereziny marked this conversation as resolved

ylukoyan force-pushed fixture_start_storage from 6e0d4ed9a1 to fa87303867

2023-05-26 11:39:41 +00:00

Compare

ylukoyan requested review from abereziny 2023-05-26 11:39:53 +00:00

ylukoyan requested review from anikeev-yadro 2023-05-26 11:40:11 +00:00

JuliaKovshova approved these changes 2023-05-26 11:43:46 +00:00

anikeev-yadro approved these changes 2023-05-26 14:54:35 +00:00

abereziny approved these changes 2023-05-29 08:09:54 +00:00

abereziny merged commit a26f8e9c80 into master

2023-05-29 14:01:58 +00:00