[#307] added methods for testing MFA #307

Merged
r.chernykh merged 1 commit from r.chernykh/frostfs-testlib:feature--10059-MFA into master 2024-11-18 07:08:44 +00:00
Member

Signed-off-by: Roman Chernykh r.chernykh@yadro.com

Signed-off-by: Roman Chernykh <r.chernykh@yadro.com>
r.chernykh added 1 commit 2024-10-21 11:04:41 +00:00
[] create autotests for MFA
Some checks failed
DCO action / DCO (pull_request) Has been cancelled
577ec5ce27
Signed-off-by: Roman Chernykh <r.chernykh@yadro.com>
r.chernykh changed title from [] create autotests for MFA to [#307] create autotests for MFA 2024-10-21 11:04:53 +00:00
r.chernykh requested review from qa-developers 2024-10-21 11:11:15 +00:00
r.chernykh requested review from qa-committers 2024-10-21 11:11:17 +00:00
abereziny approved these changes 2024-10-21 11:14:32 +00:00
Dismissed
abereziny reviewed 2024-10-21 11:33:47 +00:00
@ -1259,0 +1321,4 @@
return response
@reporter.step("Get session token to user")
Member

for user

`for user`
r.chernykh marked this conversation as resolved
r.chernykh added 1 commit 2024-10-23 17:48:52 +00:00
[] added a custom name for the generated file
Some checks failed
DCO action / DCO (pull_request) Has been cancelled
44bda557d3
Signed-off-by: Roman Chernykh <r.chernykh@yadro.com>
r.chernykh dismissed abereziny's review 2024-10-23 17:48:52 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

r.chernykh added 1 commit 2024-10-28 16:15:00 +00:00
[] Fix iam_list_virtual_mfa_devices
Some checks failed
DCO action / DCO (pull_request) Has been cancelled
06a4416f10
Signed-off-by: Roman Chernykh <r.chernykh@yadro.com>
r.chernykh added 1 commit 2024-10-28 16:35:30 +00:00
[OBJECT-10059] Fix list_mfa and get_session_token
Some checks failed
DCO action / DCO (pull_request) Has been cancelled
53f99ebb10
r.chernykh requested review from qa-committers 2024-10-29 07:34:01 +00:00
r.chernykh added 1 commit 2024-10-30 07:03:25 +00:00
Merge branch 'master' into feature--10059-MFA
Some checks failed
DCO action / DCO (pull_request) Has been cancelled
0204d93986
r.chernykh force-pushed feature--10059-MFA from 0204d93986 to a53c57e168 2024-10-30 14:28:53 +00:00 Compare
r.chernykh force-pushed feature--10059-MFA from a53c57e168 to 92d3c504cb 2024-10-31 14:19:40 +00:00 Compare
r.chernykh changed title from [#307] create autotests for MFA to [#307] added methods for testing MFA 2024-10-31 14:20:15 +00:00
r.chernykh force-pushed feature--10059-MFA from 92d3c504cb to 17a4d78190 2024-11-06 11:59:36 +00:00 Compare
abereziny approved these changes 2024-11-06 12:07:59 +00:00
Dismissed
@ -931,0 +982,4 @@
return response
@reporter.step("Get session token to user")
Member

for user

`for user`
r.chernykh marked this conversation as resolved
d.zayakin approved these changes 2024-11-06 12:13:37 +00:00
Dismissed
i.niyazov reviewed 2024-11-06 12:51:35 +00:00
@ -1443,0 +1455,4 @@
serial_number = response.get("VirtualMFADevice", {}).get("SerialNumber")
assert serial_number, f"Expected SerialNumber in response:\n{response}"
return serial_number, False
Member

Why did you return tuple [serial_number, False]?
if the second argument is required than change function typing to tuple[str, bool]

Why did you return tuple [serial_number, False]? if the second argument is required than change function typing to tuple[str, bool]
r.chernykh marked this conversation as resolved
i.niyazov reviewed 2024-11-06 12:52:35 +00:00
@ -1443,0 +1506,4 @@
@reporter.step("Get session token for user")
def sts_get_session_token(
self, duration_seconds: Optional[str] = None, serial_number: Optional[str] = None, token_code: Optional[str] = None
) -> dict:
Member

fix typing dict -> tuple

fix typing `dict` -> `tuple`
r.chernykh marked this conversation as resolved
r.chernykh force-pushed feature--10059-MFA from 17a4d78190 to 0b45deac76 2024-11-06 14:25:42 +00:00 Compare
r.chernykh dismissed abereziny's review 2024-11-06 14:25:42 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

r.chernykh dismissed d.zayakin's review 2024-11-06 14:25:42 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

r.chernykh force-pushed feature--10059-MFA from 0b45deac76 to 8206fbf72e 2024-11-06 16:46:21 +00:00 Compare
Member

Now you have different signatures in boto3 and aws with iam_create_virtual_mfa_device methods
-> tuple[str, bool]:
-> tuple
-> dict

Now you have different signatures in boto3 and aws with `iam_create_virtual_mfa_device` methods `-> tuple[str, bool]:` `-> tuple` `-> dict`
abereziny reviewed 2024-11-08 14:31:15 +00:00
r.chernykh added 2 commits 2024-11-11 08:03:25 +00:00
Signed-off-by: Kirill Sosnovskikh <k.sosnovskikh@yadro.com>
r.chernykh force-pushed feature--10059-MFA from 22b4a435e8 to 05380a8605 2024-11-11 08:04:16 +00:00 Compare
i.niyazov approved these changes 2024-11-11 08:09:01 +00:00
Dismissed
abereziny approved these changes 2024-11-11 11:10:54 +00:00
Dismissed
Member

Please merge commits in one

Please merge commits in one
abereziny requested changes 2024-11-11 11:16:58 +00:00
Dismissed
abereziny left a comment
Member

Remove OBJECT from commit messages, it should be [#<PR-number>] <message>

Remove OBJECT from commit messages, it should be `[#<PR-number>] <message>`
r.chernykh force-pushed feature--10059-MFA from 05380a8605 to cd525b2dd5 2024-11-11 13:11:08 +00:00 Compare
r.chernykh force-pushed feature--10059-MFA from cd525b2dd5 to a77fdc3be0 2024-11-11 13:25:22 +00:00 Compare
r.chernykh force-pushed feature--10059-MFA from a77fdc3be0 to 2089578f94 2024-11-12 08:25:35 +00:00 Compare
r.chernykh dismissed i.niyazov's review 2024-11-12 08:25:35 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

r.chernykh scheduled this pull request to auto merge when all checks succeed 2024-11-12 08:28:51 +00:00
r.chernykh requested review from abereziny 2024-11-12 08:44:59 +00:00
abereziny approved these changes 2024-11-12 13:08:09 +00:00
ylukoyan approved these changes 2024-11-18 07:08:39 +00:00
r.chernykh merged commit a1953684b8 into master 2024-11-18 07:08:44 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testlib#307
No description provided.