Add interface for get_list_of_all_pilorama function #31

ylukoyan · 2023-05-30T16:16:02Z

ylukoyan commented

2023-05-30 16:16:02 +00:00

No description provided.

ylukoyan added 1 commit 2023-05-30 16:16:03 +00:00

Add interface for get_list_of_all_pilorama function 8dab9735cf

ylukoyan requested review from qa-committers 2023-05-30 16:29:17 +00:00

ylukoyan requested review from qa-developers 2023-05-30 16:29:17 +00:00

ylukoyan requested review from anikeev-yadro 2023-05-30 16:29:25 +00:00

ylukoyan requested review from abereziny 2023-05-30 16:29:25 +00:00

abereziny requested changes 2023-05-30 16:45:42 +00:00

src/frostfs_testlib/storage/dataclasses/frostfs_services.py

					
				@ -178,2 +178,4 @@

				        self.host.delete_pilorama(self.name)

				    def get_list_of_all_pilorama(self):

				        return self.host.get_list_of_all_pilorama(self.name)

abereziny commented

2023-05-30 16:45:33 +00:00

Currenlty, host has no get_list_of_all_pilorama

Currenlty, `host` has no `get_list_of_all_pilorama`

abereziny commented

2023-05-30 16:51:56 +00:00

It's getting out of control, we have too many similar little functions which do something with data_directory_path which requires to add new methods to 3 repos (testlib + 2 plugins).

I propose to continue with better approach regarding these.

Add method get_data_directory to host interface and support it in 3 repos (testlib + 2 plugins)
Unless there are significant differences between plugins - any new methods which requires data_directory manipulations should be coded in steps folder or inside cluster classes (ClusterNode/NodeBase)

This way we will need to support new such methods only in 1 repo instead of 3.

It's getting out of control, we have too many similar little functions which do something with `data_directory_path` which requires to add new methods to 3 repos (testlib + 2 plugins). I propose to continue with better approach regarding these. 1. Add method `get_data_directory` to host interface and support it in 3 repos (testlib + 2 plugins) 2. Unless there are significant differences between plugins - any new methods which requires data_directory manipulations should be coded in steps folder or inside cluster classes (ClusterNode/NodeBase) This way we will need to support new such methods only in 1 repo instead of 3.

👀 1

ylukoyan commented

2023-06-01 05:59:04 +00:00

I'll make another PR with proposed changes

ylukoyan closed this pull request

2023-06-01 05:59:05 +00:00