Refine CODEOWNERS settings #336

potyarkin · 2024-12-10T13:12:27Z

potyarkin commented

2024-12-10 13:12:27 +00:00

CODEOWNERS file specifies reviewers which will be automatically added to each PR.

Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools:

Filepaths are matched using Golang regex library instead of simple fileglobs
All matching lines are active instead of only the first one
There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name)

This PR is a part of multirepo cleanup effort: TrueCloudLab/frostfs-infra#90

CODEOWNERS file specifies reviewers which will be automatically added to each PR. Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools: - Filepaths are matched using Golang regex library instead of simple fileglobs - All matching lines are active instead of only the first one - There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name) This PR is a part of multirepo cleanup effort: https://git.frostfs.info/TrueCloudLab/frostfs-infra/issues/90

potyarkin added 1 commit 2024-12-10 13:12:28 +00:00

[#] Refine CODEOWNERS settings

DCO action / DCO (pull_request) Has been cancelled

Details

eea3dc9c70

Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>

potyarkin requested review from abereziny 2024-12-10 13:12:28 +00:00

potyarkin requested review from d.zayakin 2024-12-10 13:12:28 +00:00

potyarkin requested review from anikeev-yadro 2024-12-10 13:12:28 +00:00

potyarkin requested review from anurindm 2024-12-10 13:12:28 +00:00

potyarkin requested review from ylukoyan 2024-12-10 13:12:28 +00:00

potyarkin requested review from i.niyazov 2024-12-10 13:12:28 +00:00

potyarkin requested review from JuliaKovshova 2024-12-10 13:12:28 +00:00

potyarkin force-pushed feature/codeowners from eea3dc9c70 to d4d344ce64

2024-12-10 13:21:06 +00:00

Compare

abereziny requested changes 2024-12-11 16:15:54 +00:00

Dismissed

CODEOWNERS

					
				@ -1 +1,3 @@

				*       @JuliaKovshova @abereziny @d.zayakin @anikeev-yadro @anurindm @ylukoyan @i.niyazov

				.*           @TrueCloudLab/qa-committers

				.forgejo/.* @potyarkin

				Makefile    @potyarkin

abereziny commented

2024-12-11 16:15:51 +00:00

I wouldn't agree with that line.
Makefile contains tests scripts which used in testing platform, so it's also @TrueCloudLab/qa-committers

I wouldn't agree with that line. Makefile contains tests scripts which used in testing platform, so it's also @TrueCloudLab/qa-committers

potyarkin commented

2024-12-12 07:28:07 +00:00

That's the quirk of Forgejo CODEOWNERS parser: it creates review requests for ALL matching lines, not just for the last one. So for Makefile changes reviewers will be both qa-commiters and me.