TrueCloudLab/frostfs-testlib
25
0
Fork 20
Code Issues Pull requests 1 Releases 1 Activity Actions

Refine CODEOWNERS settings #336

Merged
abereziny merged 1 commit from potyarkin/frostfs-testlib:feature/codeowners into master 2024-12-25 09:53:49 +00:00
Conversation 0 Commits 1 Files changed 1 +3 -1
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CODEOWNERS
View file

@ -1 +1,3 @@
* @JuliaKovshova @abereziny @d.zayakin @anikeev-yadro @anurindm @ylukoyan @i.niyazov
.* @TrueCloudLab/qa-committers
.forgejo/.* @potyarkin
Makefile @potyarkin
abereziny marked this conversation as resolved
abereziny commented 2024-12-11 16:15:51 +00:00
Review
Copy link

I wouldn't agree with that line.
Makefile contains tests scripts which used in testing platform, so it's also @TrueCloudLab/qa-committers

I wouldn't agree with that line. Makefile contains tests scripts which used in testing platform, so it's also @TrueCloudLab/qa-committers
potyarkin commented 2024-12-12 07:28:07 +00:00
Review
Copy link

That's the quirk of Forgejo CODEOWNERS parser: it creates review requests for ALL matching lines, not just for the last one. So for Makefile changes reviewers will be both qa-commiters and me.

That's the quirk of Forgejo CODEOWNERS parser: it creates review requests for ALL matching lines, not just for the last one. So for Makefile changes reviewers will be both qa-commiters and me.