[#338] Added ns args for func container create #339

d.zayakin · 2024-12-17T10:00:13Z

d.zayakin commented

2024-12-17 10:00:13 +00:00

Signed-off-by: Dmitriy Zayakin d.zayakin@yadro.com

Signed-off-by: Dmitriy Zayakin <d.zayakin@yadro.com>

d.zayakin added 1 commit 2024-12-17 10:00:13 +00:00

[#338 ] Added ns args for func container create

DCO action / DCO (pull_request) Successful in 1m49s

Details

890e1288a9

Signed-off-by: Dmitriy Zayakin <d.zayakin@yadro.com>

d.zayakin requested review from i.niyazov 2024-12-17 10:00:13 +00:00

d.zayakin requested review from JuliaKovshova 2024-12-17 10:00:13 +00:00

d.zayakin requested review from abereziny 2024-12-17 10:00:13 +00:00

d.zayakin requested review from anikeev-yadro 2024-12-17 10:00:13 +00:00

d.zayakin requested review from anurindm 2024-12-17 10:00:13 +00:00

d.zayakin requested review from ylukoyan 2024-12-17 10:00:13 +00:00

d.zayakin force-pushed added-ns-args-for-container-create from 890e1288a9 to 7dd10231fe

2024-12-17 10:03:26 +00:00

Compare

d.zayakin removed review request for i.niyazov 2024-12-17 10:04:05 +00:00

d.zayakin removed review request for JuliaKovshova 2024-12-17 10:04:06 +00:00

d.zayakin removed review request for abereziny 2024-12-17 10:04:07 +00:00

d.zayakin removed review request for anikeev-yadro 2024-12-17 10:04:08 +00:00

d.zayakin removed review request for anurindm 2024-12-17 10:04:09 +00:00

d.zayakin removed review request for ylukoyan 2024-12-17 10:04:10 +00:00

Kiriruso approved these changes 2024-12-17 10:32:00 +00:00

Dismissed

Kiriruso reviewed 2024-12-17 10:33:54 +00:00

src/frostfs_testlib/steps/cli/container.py Outdated

					
				@ -112,2 +112,4 @@

				    await_mode: bool = True,

				    wait_for_creation: bool = True,

				    nns_zone: str = None,

				    nns_name: str = None,

Kiriruso commented

2024-12-17 10:33:40 +00:00

Optional[str]

`Optional[str]`

👍 2

abereziny commented

2024-12-17 10:52:06 +00:00

Optional[str]

or
str | None

> `Optional[str]` or `str | None`

d.zayakin commented

2024-12-17 10:55:46 +00:00

done

d.zayakin marked this conversation as resolved

d.zayakin force-pushed added-ns-args-for-container-create from 7dd10231fe to cc7bd4ffc9

2024-12-17 10:55:39 +00:00

Compare

d.zayakin dismissed Kiriruso's review 2024-12-17 10:55:41 +00:00

Reason:

New commits pushed, approval review dismissed automatically according to repository settings

abereziny approved these changes 2024-12-17 11:00:04 +00:00

Kiriruso approved these changes 2024-12-17 12:08:14 +00:00

d.zayakin scheduled this pull request to auto merge when all checks succeed 2024-12-17 12:16:21 +00:00

d.zayakin canceled auto merging this pull request when all checks succeed 2024-12-17 12:16:59 +00:00

i.niyazov approved these changes 2024-12-17 14:15:36 +00:00

d.zayakin merged commit cc7bd4ffc9 into master

2024-12-17 14:17:58 +00:00

d.zayakin deleted branch added-ns-args-for-container-create

2024-12-17 14:17:59 +00:00

d.zayakin referenced this pull request from a commit

2024-12-17 14:18:00 +00:00

[#339] Added ns args for func container create

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testlib#339