TrueCloudLab/frostfs-testlib

Fix division by zero, when total k6 operations is zero #64

Merged

mmalygina merged 1 commit from mmalygina/frostfs-testlib:fix-divizion-by-zero into master

2023-07-27 13:42:07 +00:00

mmalygina commented

2023-07-26 16:12:33 +00:00

Member

Write 4GB 30min 50th test fails with error:

ERRO[09:22:09] context deadline exceeded

Summary json:
summary.txt

Therefore there is no metrics.write_total_iterations in summary.json, so write_operations is assigned 0 и auto-test fails with "ZeroDivisionError: division by zero" when errors percent is calculated
in Jenkins build log:

[2023-07-26T09:29:46.117Z] >       if writers and write_errors / write_operations * 100 > self.load_params.error_threshold:
[2023-07-26T09:29:46.117Z] E       ZeroDivisionError: division by zero

Write 4GB 30min 50th test fails with error: ``` ERRO[09:22:09] context deadline exceeded ``` Summary json: [summary.txt](/attachments/2ed803d4-0d71-482a-bcd7-3780d5af37c7) Therefore there is no metrics.write_total_iterations in summary.json, so write_operations is assigned 0 и auto-test fails with "ZeroDivisionError: division by zero" when errors percent is calculated in Jenkins build log: ``` [2023-07-26T09:29:46.117Z] > if writers and write_errors / write_operations * 100 > self.load_params.error_threshold: [2023-07-26T09:29:46.117Z] E ZeroDivisionError: division by zero ```

summary.txt

759 B

mmalygina requested review from abereziny 2023-07-26 16:13:18 +00:00

mmalygina requested review from d.zayakin 2023-07-26 16:13:26 +00:00

mmalygina requested review from ylukoyan 2023-07-26 16:13:43 +00:00

abereziny approved these changes 2023-07-26 16:14:41 +00:00

abereziny commented

2023-07-26 16:15:29 +00:00

Member

Strange to me to have 0 VUs :)

Strange to me to have 0 VUs :)

anikeev-yadro approved these changes 2023-07-27 06:39:48 +00:00

d.zayakin approved these changes 2023-07-27 07:56:41 +00:00

mmalygina requested review from d.zayakin 2023-07-27 08:00:08 +00:00

mmalygina requested review from JuliaKovshova 2023-07-27 08:00:21 +00:00

mmalygina commented

2023-07-27 08:00:52 +00:00

Author

Member

Fix was tested in Rock&Roll write 4GB 30min 50th - https://obj-jenkins.spb.yadro.com/job/frostfs_tatlin_object_to_baremetal_test/132/

Fix was tested in _Rock&Roll write 4GB 30min 50th_ - https://obj-jenkins.spb.yadro.com/job/frostfs_tatlin_object_to_baremetal_test/132/

ylukoyan approved these changes 2023-07-27 11:01:18 +00:00

mmalygina force-pushed fix-divizion-by-zero from bc0b0bfc12 to d6e08c477b

2023-07-27 11:33:45 +00:00

Compare

d.zayakin approved these changes 2023-07-27 11:42:40 +00:00

JuliaKovshova approved these changes 2023-07-27 12:30:00 +00:00

mmalygina merged commit d6e08c477b into master

2023-07-27 13:42:07 +00:00

mmalygina deleted branch fix-divizion-by-zero

2023-07-27 13:42:08 +00:00

Sign in to join this conversation.

No reviewers

No labels

good first issue

No milestone

No project

No assignees

6 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testlib#64

No description provided.