TrueCloudLab/frostfs.info
6
0
Fork 3
Code Issues 9 Pull requests 1 Projects Activity Actions

Fix FEP number missing in FEP page header #10

Merged
corsairdnb merged 2 commits from bug/7-fep_number_in_header into master 2023-02-15 11:43:41 +00:00
Conversation 1 Commits 2 Files changed 2 +2 -1
corsairdnb commented 2023-02-14 10:31:18 +00:00 (Migrated from github.com)
Copy link

Add FEP number in page title.

Closes: #7

Add FEP number in page title. Closes: #7
alexvanin (Migrated from github.com) reviewed 2023-02-15 07:48:12 +00:00
layouts/partials/title.html
alexvanin (Migrated from github.com) commented 2023-02-15 07:48:10 +00:00
Copy link

By the way, do we have any policies of having \n in the end of files or not?

By the way, do we have any policies of having `\n` in the end of files or not?
realloc (Migrated from github.com) reviewed 2023-02-15 07:52:00 +00:00
layouts/partials/title.html
realloc (Migrated from github.com) commented 2023-02-15 07:51:59 +00:00
Copy link

Having EOL at the end of file seems to be the universal standard. We should follow it unless we know exactly why we don't need EOL at some place.

Having EOL at the end of file seems to be the universal standard. We should follow it unless we know exactly why we don't need EOL at some place.
corsairdnb commented 2023-02-15 09:46:34 +00:00 (Migrated from github.com)
Copy link

@realloc @alexvanin review please :)

@realloc @alexvanin review please :)
realloc (Migrated from github.com) approved these changes 2023-02-15 11:40:31 +00:00
realloc (Migrated from github.com) left a comment
Copy link

Added theme submodule update to keep it consistent

Added theme submodule update to keep it consistent
alexvanin (Migrated from github.com) approved these changes 2023-02-15 11:42:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
realloc
alexvanin
Labels
Clear labels   
FEP

FrostFS Enhancement Proposal

  
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
theme

Hugo theme and visual elements

  
yaczrokh

YADRO

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
FEP
P0
P1
P2
P3
good first issue
theme
yaczrokh
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs.info#10
No description provided.
Delete branch "bug/7-fep_number_in_header"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?