noliteral: add noliteral configuration #6

achuprov · 2023-07-31T14:29:23Z

achuprov commented

2023-07-31 14:29:23 +00:00

Added noliteral configuration for golangci >= 1.5.4.

achuprov force-pushed noliteral-configuration from 9cddefcc6b to 1cbb08eea4

2023-07-31 14:45:45 +00:00

Compare

acid-ant requested changes 2023-07-31 14:51:19 +00:00

internal/analyzers/noliteral/linter.go Outdated

					
				@ -16,3 +16,3 @@

				}

				var methodsToSearch = []string{"Debug", "Info", "Warn", "Error", "reportFlushError", "reportError"}

				type Сonfiguration struct {

acid-ant commented

2023-07-31 14:50:38 +00:00

Looks like you use here and below Cyrillic C instead of Latin.

achuprov commented

2023-08-01 10:53:25 +00:00

fixed

acid-ant marked this conversation as resolved

achuprov requested review from storage-core-committers 2023-07-31 14:54:07 +00:00

achuprov requested review from storage-core-developers 2023-07-31 14:54:07 +00:00

dstepanov-yadro requested changes 2023-08-01 09:22:02 +00:00

internal/analyzers/noliteral/linter.go Outdated

					
				@ -17,2 +17,3 @@

				var methodsToSearch = []string{"Debug", "Info", "Warn", "Error", "reportFlushError", "reportError"}

				type Сonfiguration struct {

					MethodsToSearch []string `mapstructure:"target-methods"`

dstepanov-yadro commented

2023-08-01 09:21:31 +00:00

Is this tag required?

achuprov commented

2023-08-01 10:55:50 +00:00

I change the variable name, but I left tag.

main.go Outdated

					
				@ -15,0 +17,4 @@

				// for version ci-lint >= '1.5.4'.

				func New(conf any) ([]*analysis.Analyzer, error) {

					var config noliteral.Сonfiguration

dstepanov-yadro commented

2023-08-01 09:20:31 +00:00

here too

achuprov force-pushed noliteral-configuration from 1cbb08eea4 to e59c69bf24

2023-08-01 10:42:12 +00:00

Compare

dstepanov-yadro approved these changes 2023-08-01 10:55:48 +00:00

fyrchik approved these changes 2023-08-01 10:59:21 +00:00

internal/analyzers/noliteral/linter_test.go Outdated

					
				@ -33,3 +33,3 @@

					_, err = run(pass)

					if Count != 6 {

					if Count != 4 {

fyrchik commented

2023-08-01 10:58:43 +00:00

From 1 magic number to another, can we replace with a constant/some function? Is this len(Config.TargetMethods?

From 1 magic number to another, can we replace with a constant/some function? Is this `len(Config.TargetMethods`?

👍 1

main.go Outdated

					
				@ -15,0 +19,4 @@

				func New(conf any) ([]*analysis.Analyzer, error) {

					var config noliteral.Configuration

					if confMap, ok := conf.(map[string]interface{}); ok {