TrueCloudLab/linters
22
0
Fork 7
generated from TrueCloudLab/basic
Code Issues 5 Pull requests 1 Projects Releases 1 Packages Wiki Activity Actions

noliteral: add noliteral configuration #6

Merged
dstepanov-yadro merged 2 commits from achuprov/linters:noliteral-configuration into master 2024-09-04 19:51:22 +00:00
Conversation 0 Commits 2 Files changed 8 +3 -14
3 changed files with 3 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit a1a45f5368 - Show all commits

4
internal/analyzers/noliteral/linter_test.go
View file

@ -12,6 +12,8 @@ import (
)
func TestAnalyzer_negative(t *testing.T) {
const countNegativeCases = 4
_, filename, _, _ := runtime.Caller(0)
dir := filepath.Dir(filename)
@ -32,7 +34,7 @@ func TestAnalyzer_negative(t *testing.T) {
_, err = run(pass)
fyrchik commented 2023-08-01 10:58:43 +00:00
Outdated
Review
Copy link

From 1 magic number to another, can we replace with a constant/some function? Is this len(Config.TargetMethods?

From 1 magic number to another, can we replace with a constant/some function? Is this `len(Config.TargetMethods`?
👍 1
if Count != 6 {
if Count != countNegativeCases {
t.Fail()
}
if err != nil {

9
internal/analyzers/noliteral/test-case/src/negative._go
View file

@ -17,15 +17,6 @@ func (c *cfg) error_n() {
c.log.Error("logs.MSG") //unacceptable
}
func (c *cfg) reportFlushError_n() {
c.log.reportFlushError("logs.MSG") //unacceptable
}
func (c *cfg) reportError_n() {
c.log.reportError("logs.MSG") //unacceptable
}
type Logger interface {
Debug(msg string)

4
internal/analyzers/noliteral/test-case/src/positive._go
View file

@ -24,10 +24,6 @@ func (c *cfg) custom_ok_lit() {
c.log.Abyr("logs.MSG") //acceptable
}
func (c *cfg) custom_ok_lit() {
log.Abyr("logs.MSG") //acceptable
}
type Logger interface {
Debug(msg string)
Info(msg string)