[#9] makefile: add env CGO_ENABLED #9

Closed
achuprov wants to merge 1 commit from achuprov/linters:master into master
Member

To use dynamic linking, CGO must be enabled

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

To use dynamic linking, CGO must be enabled Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2023-08-11 09:26:59 +00:00
[#9] makefile: add env CGO_ENABLED
All checks were successful
Tests and linters / Tests (pull_request) Successful in 4m37s
Tests and linters / Build lib (pull_request) Successful in 4m48s
Tests and linters / Staticcheck (pull_request) Successful in 6m15s
Tests and linters / Lint (pull_request) Successful in 12m50s
f104963409
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
fyrchik reviewed 2023-08-11 09:47:22 +00:00
@ -7,3 +7,3 @@
lib:
@mkdir -pv $(OUT_DIR)
@go build -buildmode=plugin -o $(OUT_DIR)/external_linters.so $(PLUGIN_SOURCE)
@CGO_ENABLED=1 go build -buildmode=plugin -o $(OUT_DIR)/external_linters.so $(PLUGIN_SOURCE)
Owner

Why do we need it here? I believe we need it only in an application that loads plugin.

Why do we need it here? I believe we need it only in an application that _loads_ plugin.
achuprov closed this pull request 2023-08-14 14:56:49 +00:00
All checks were successful
Tests and linters / Tests (pull_request) Successful in 4m37s
Tests and linters / Build lib (pull_request) Successful in 4m48s
Tests and linters / Staticcheck (pull_request) Successful in 6m15s
Tests and linters / Lint (pull_request) Successful in 12m50s

Pull request closed

Sign in to join this conversation.
No description provided.