TrueCloudLab/multinet
20
0
Fork 2
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Use source IPs instead of interfaces #11

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/multinet:fix/use_source_ips into master 2024-11-02 14:21:56 +00:00
Conversation 0 Commits 1 Files changed 1 +25 -2
dstepanov-yadro commented 2024-10-09 13:07:07 +00:00
Member
Copy link
  • instead of using network interfaces now Dialer receives a list of source IPs to balance requests between them
  • added static checkers
  • added CI/CD steps
- instead of using network interfaces now Dialer receives a list of source IPs to balance requests between them - added static checkers - added CI/CD steps
dstepanov-yadro added 7 commits 2024-10-09 13:07:07 +00:00 
The use of network interfaces does not cover cases where it is necessary
to use network interfaces to access different subnets.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/use_source_ips from 3d30d7eb12 to f940027c55 2024-10-09 13:10:27 +00:00 Compare
dstepanov-yadro force-pushed fix/use_source_ips from f940027c55 to 7620486bcb 2024-10-09 13:14:06 +00:00 Compare
dstepanov-yadro force-pushed fix/use_source_ips from 7620486bcb to e26675c84b 2024-10-09 13:20:12 +00:00 Compare
dstepanov-yadro force-pushed fix/use_source_ips from e26675c84b to 3d779924f3 2024-10-09 13:22:57 +00:00 Compare
dstepanov-yadro force-pushed fix/use_source_ips from 3d779924f3 to c4a6d20d37 2024-10-09 13:30:20 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-10-09 13:33:50 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-10-09 13:33:50 +00:00
dstepanov-yadro removed review request for storage-core-committers 2024-10-09 15:23:34 +00:00
dstepanov-yadro removed review request for storage-core-developers 2024-10-09 15:23:36 +00:00
dstepanov-yadro requested review from storage-core-committers 2024-10-14 07:21:06 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-10-14 07:21:07 +00:00
dstepanov-yadro changed title from WIP: Use source IPs instead of interfaces to Use source IPs instead of interfaces 2024-10-14 07:21:14 +00:00
dstepanov-yadro added 1 commit 2024-10-15 07:56:57 +00:00
[#11] dialer: Add event handler
All checks were successful
Tests and linters / Tests with -race (pull_request) Successful in 28s
Details
Vulncheck / Vulncheck (pull_request) Successful in 45s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 54s
Details
Tests and linters / Tests (pull_request) Successful in 1m3s
Details
Tests and linters / gopls check (pull_request) Successful in 1m1s
Details
DCO action / DCO (pull_request) Successful in 1m17s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m20s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m40s
Details
Tests and linters / Lint (pull_request) Successful in 2m5s
Details
6cb0d80e09 
Could be used for metrics and failover scenarios.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
fyrchik approved these changes 2024-10-15 08:53:15 +00:00
dialer.go
@ -48,2 +40,4 @@
// See Config.FallbackDelay description.
fallbackDelay time.Duration
// Event handler.
eh EventHandler
fyrchik commented 2024-10-15 08:53:11 +00:00
Owner
Copy link

What is the usecase for this, besides tests?

What is the usecase for this, besides tests?
dstepanov-yadro commented 2024-10-15 09:57:00 +00:00
Author
Member
Copy link

Metrics, logging, failover

Metrics, logging, failover
fyrchik marked this conversation as resolved
achuprov approved these changes 2024-10-15 12:36:12 +00:00
elebedeva approved these changes 2024-10-15 13:04:01 +00:00
dstepanov-yadro merged commit 6cb0d80e09 into master 2024-10-15 13:25:00 +00:00
dstepanov-yadro referenced this pull request from a commit 2024-10-15 13:25:02 +00:00
[#11] mod: Bump go version
dstepanov-yadro referenced this pull request from a commit 2024-10-15 13:25:02 +00:00
[#11] mod: Bump deps versions
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
achuprov
elebedeva
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/multinet#11
No description provided.
Delete branch "dstepanov-yadro/multinet:fix/use_source_ips"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?