Add default dialer #8

dstepanov-yadro · 2023-10-30T10:31:58Z

dstepanov-yadro commented

2023-10-30 10:31:58 +00:00

Add default dialer to substitute net.Dial.

Closes #3

Add default dialer to substitute `net.Dial`. Closes #3

dstepanov-yadro reviewed 2023-10-30 10:32:42 +00:00

default.go Outdated

					
				@ -0,0 +14,4 @@

				func init() {

					var err error

					defaultDialer, err = NewDialer(Config{

						Balancer: BalancerTypeRoundRobin,

dstepanov-yadro commented

2023-10-30 10:32:42 +00:00

It looks like if balancer will be noop then there is no difference with net.Dial

It looks like if balancer will be `noop` then there is no difference with `net.Dial`

👍 1

dstepanov-yadro requested review from storage-core-committers 2023-10-30 10:32:54 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-10-30 10:32:54 +00:00

acid-ant approved these changes 2023-10-30 11:20:48 +00:00

fyrchik reviewed 2023-10-30 13:06:47 +00:00

default.go Outdated

					
				@ -0,0 +15,4 @@

					var err error

					defaultDialer, err = NewDialer(Config{

						Balancer: BalancerTypeRoundRobin,

						Subnets:  []string{"0.0.0.0/0", "0000:0000:0000:0000:0000:0000:0000:0000/0"},

fyrchik commented

2023-10-30 13:04:08 +00:00

Does ::/0 or ::0/0work?

Does `::/0` or `::0/0`work?

dstepanov-yadro commented

2023-10-30 13:43:31 +00:00

yes, fixed

fyrchik marked this conversation as resolved

default_test.go Outdated

					
				@ -0,0 +9,4 @@

				)

				func TestDefaultDialer(t *testing.T) {

					conn, err := Dial("tcp", "s01.frostfs.devenv:8080")

fyrchik commented

2023-10-30 13:06:19 +00:00

We add devenv requirement to the integration, how setting up a small server in tests?

dstepanov-yadro commented

2023-10-30 13:43:44 +00:00

fixed

fyrchik marked this conversation as resolved

fyrchik reviewed 2023-10-30 13:15:20 +00:00

default.go Outdated

					
				@ -0,0 +22,4 @@

					}

				}

				// Dial dials provided network and address using defaule dialer.

fyrchik commented

2023-10-30 13:15:20 +00:00

s/defaule/default/

dstepanov-yadro commented

2023-10-30 13:43:37 +00:00

fixed

fyrchik marked this conversation as resolved

dstepanov-yadro force-pushed feat/default_dialer from 4159d54f64 to 70349432df

2023-10-30 13:43:21 +00:00

Compare

aarifullin reviewed 2023-11-02 09:11:37 +00:00

default_test.go Outdated

					
				@ -0,0 +16,4 @@

					conn, err := Dial("tcp", "localhost:8080")

					require.NoError(t, err)

					if err == nil {

aarifullin commented

2023-11-02 09:11:37 +00:00

err is already nil if it has just passed require.NoError(t, err)?

`err` is already `nil` if it has just passed `require.NoError(t, err)`?

dstepanov-yadro commented

2023-11-02 10:26:23 +00:00

Fixed

aarifullin marked this conversation as resolved

fyrchik approved these changes 2023-11-02 09:24:44 +00:00

dstepanov-yadro force-pushed feat/default_dialer from 70349432df to 76e736f572

2023-11-02 10:26:14 +00:00

Compare

aarifullin approved these changes 2023-11-02 10:37:58 +00:00

fyrchik merged commit 76e736f572 into master

2023-11-02 11:59:06 +00:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/multinet#8