TrueCloudLab/neoneo-go
7
0
Fork 2
Code Issues Pull requests Projects Releases Packages Wiki Activity
5317 commits 34 branches 134 tags 35 MiB
Commit graph

5317 commits

This branch
This branch
All branches
Author SHA1 Message Date
Evgeniy Stratonikov
4ab18d084a rpc/request: add unmarshal benchmark 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-11-01 17:21:04 +03:00
Roman Khimov
1d16016027
Merge pull request #2217 from nspcc-dev/compiler-overload 
compiler: allow to overload methods in manifest
 2021-11-01 14:49:43 +03:00
Roman Khimov
fe50f6edc7
Merge pull request #2240 from nspcc-dev/fix-panic-in-network 
Fix panic on peer disconnect
 2021-11-01 12:44:15 +03:00
Roman Khimov
774dee3cd4 network: fix disconnection race between handleConn() and handleIncoming() 
handleIncoming() winning the race for p.Disconnect() call might lead to nil
error passed as the reason for peer unregistration.
 2021-11-01 12:20:55 +03:00
Roman Khimov
2eeec73770 network: don't panic if there is no reason for disconnect 
Although error should always be there, we shouldn't fail like this if it's not:
    | panic: runtime error: invalid memory address or nil pointer dereference
    | [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0xc8884c]
    |
    | goroutine 113 [running]:
    | github.com/nspcc-dev/neo-go/pkg/network.(*Server).run(0xc000150580)
    |         github.com/nspcc-dev/neo-go/pkg/network/server.go:396 +0x7ac
    | github.com/nspcc-dev/neo-go/pkg/network.(*Server).Start(0xc000150580, 0x0)
    |         github.com/nspcc-dev/neo-go/pkg/network/server.go:294 +0x3fb
    | created by github.com/nspcc-dev/neo-go/cli/server.startServer
    |         github.com/nspcc-dev/neo-go/cli/server/server.go:344 +0x56f
 2021-11-01 12:19:00 +03:00
Roman Khimov
328f8b7954
Merge pull request #2238 from nspcc-dev/fix-block-queue 
network: remove priority queue from block queue
 2021-11-01 12:03:45 +03:00
Roman Khimov
48668afa7a
Merge pull request #2237 from nspcc-dev/convert-base64-address 
vmcli: convert base64 string to address in `parse`
 2021-11-01 11:52:34 +03:00
Roman Khimov
8bb1ecb45a network: remove priority queue from block queue 
Use circular buffer which is a bit more appropriate. The problem is that
priority queue accepts and stores equal items which wastes memory even in
normal usage scenario, but it's especially dangerous if the node is stuck for
some reason. In this case it'll accept from peers and put into queue the same
blocks again and again leaking memory up to OOM condition.

Notice that queue length calculation might be wrong in case circular buffer
wraps, but it's not very likely to happen (usually blocks not coming from the
queue are added by consensus and it's not very fast in doing so).
 2021-11-01 11:49:01 +03:00
AnnaShaleva
fbc09a415e *: fix build errors on windows 2021-11-01 11:15:35 +03:00
Evgeniy Stratonikov
7758378d28 compiler: allow to overload methods in manifest 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-10-29 20:15:21 +03:00
Evgeniy Stratonikov
51127b8918 vmcli: convert base64 string to address in parse 
In application logs hashes are serialized as base64 so it is useful
to convert them back to address via `util convert`.

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-10-29 14:55:10 +03:00
Roman Khimov
67eac3a27f
Merge pull request #2196 from nspcc-dev/drop-badger-and-redis 
Drop Badger and Redis
 2021-10-28 16:08:49 +03:00
Roman Khimov
ec47491d4d
Merge pull request #2235 from nspcc-dev/mpt/empty-batch 
core: handle empty MPT batch properly
 2021-10-27 19:14:39 +03:00
AnnaShaleva
3fed7b8eec core: handle empty MPT batch properly 
It's OK to have it.
 2021-10-27 18:44:39 +03:00
Roman Khimov
1144a03486 storage: drop RedisDB, close #2130 2021-10-27 17:32:25 +03:00
Roman Khimov
fb4b87bb96 storage: drop BadgerDB support, close #2130 2021-10-27 17:31:55 +03:00
Roman Khimov
fdf80dbdc5
Merge pull request #2225 from nspcc-dev/notary/allow-to-combine-witnesses 
notary: allow to combine signers of different types
 2021-10-26 17:54:07 +03:00
Roman Khimov
354a54c91c
Merge pull request #2232 from nspcc-dev/compiler-invalid-offset 
Set proper context during analyzing func usage
 2021-10-25 20:57:34 +03:00
AnnaShaleva
2d196b3f35 rpc: refactor calculatenetworkfee handler 
Use (Blockchainer).VerifyWitness() to calculate network fee for
contract-based witnesses.
 2021-10-25 19:07:25 +03:00
Anna Shaleva
807fa4a720 services: allow non-empty inv scripts for contract-based notary witness 2021-10-25 17:23:29 +03:00
Evgeniy Stratonikov
4fe188a60d compiler: check correctness of emitted bytecode 
The error here indicates a bug in compiler implementation.

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-10-25 13:55:55 +03:00
Evgeniy Stratonikov
a885f84cad compiler: fail if some functions are missing 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-10-25 13:55:55 +03:00
Evgeniy Stratonikov
8a0429036b compiler: set type information during traversal, fix #2231 
Set all necessary context before file traversal, not only import
maps. Also, we can skip restoring import maps because all our code is
processed via `For*` iterators which set necessary context.
We can also refactor this a bit to have all context in one place,
this will be done in #2086.

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-10-25 13:55:55 +03:00
Roman Khimov
eea728b986
Merge pull request #2230 from nspcc-dev/inline-util 
Compile `interop/util` as a regular package
 2021-10-25 12:48:58 +03:00
Anna Shaleva
75d7891ca1 services: add ability to combine notary signers 
Notes for witnesses:
* [N sig + M multisig + K contract] combination is possible where N, M, K >=0.
* Each verification script should be properly filled in.
* Each invocation script should either be empty or contain exactly one
signature.
 2021-10-25 12:22:13 +03:00
Evgeniy Stratonikov
b91de50e65 compiler: remove convert.To* from the list of builtins 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-10-23 16:16:03 +03:00
Evgeniy Stratonikov
a92bf281c1 compiler: remove custom logic for util builtins 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-10-23 16:12:47 +03:00
Roman Khimov
6fe8f4565d
Merge pull request #2228 from nspcc-dev/additional-interop 
Constants and ABORT in interops
 2021-10-22 21:45:57 +03:00
Anna Shaleva
fcc7f7349d services: refactor the logic of notary signatures counting 
Maintain the number of signatures left to collect instead of maintaining
the number of already collected signatures and overall number of
signatures.
 2021-10-22 17:06:46 +03:00
Roman Khimov
36295357d8 interop: add Abort() function to ABORT things 
Related to #2227.
 2021-10-22 14:50:51 +03:00
Roman Khimov
6a40365e28
Merge pull request #2226 from nspcc-dev/fix-vm-cli-test 
vm: wait more for a test prog execution ending
 2021-10-22 14:41:37 +03:00
Anna Shaleva
693c376d21 vm: wait more for a test prog execution ending 2021-10-22 12:14:37 +03:00
Roman Khimov
e230040c2e interop: add canonical type lengths as constants 
Contracts need them anyway.
 2021-10-22 10:56:58 +03:00
Roman Khimov
d551439654
Merge pull request #2193 from nspcc-dev/optimize-find 
core: optimise (*MemCachedStorage).Seek
 2021-10-21 21:20:33 +03:00
Anna Shaleva
3450371910 core: split (*MemCachedStore) Seek and SeekAsync methods 
Use SeekAsync for System.Storage.Find and Seek for the rest of cases.
 2021-10-21 10:05:12 +03:00
Anna Shaleva
dcda7bec63 core: squash PS-seeking and merging routines in (*MemCachedStore).Seek 
We don't need a separate routine to merge seek results.
 2021-10-21 10:05:12 +03:00
Anna Shaleva
c88720bf45 core: remove memstore routine from (*MemCachedStore).SeekAsync 
It adds unnecessary overhead to computations.
 2021-10-21 10:05:12 +03:00
Anna Shaleva
dfe2c667e1 core: do not hold the lock while seeking over persistent store 2021-10-21 10:05:12 +03:00
Anna Shaleva
07cbe4d253 core: add finalizer functions to interop context 
These functions are aimed to free the resources occupied by storage
iterator by the end of script execution or whenever Finilize is called.
 2021-10-21 10:05:12 +03:00
Anna Shaleva
0a4f45c9b0 core: add ability to free storage.Iterator resources 2021-10-21 10:05:12 +03:00
Anna Shaleva
89ee2e7720 core: refactor storage.Find and storage.Iterator to work with channel 
Add SeekAsync methods in order to fetch matching storage items
on demand. Refactor storage.Find and storage.Iterator wrt these changes.
 2021-10-21 10:05:12 +03:00
Anna Shaleva
f2ac07a3c0 core: do not copy key/value results got from MemCachedStore.Seek 
They are already copied inside the MemCachedStore.Seek, so that
persistent storage  can't change them anymore.
 2021-10-21 10:05:12 +03:00
Anna Shaleva
72726d46d3 core: refactor callers of MemCachedStore.Seek 
MemCachedStore.Seek now sorts results, so its callers may omit sorting.
 2021-10-21 10:05:12 +03:00
Anna Shaleva
7ba88e98e2 core: optimize (*MemCachedStore).Seek operation 
Real persistent storage guarantees that result of Seek is sorted
by keys. The idea of optimisation is to merge two sorted seek
results into one (memStore+persistentStore), so that
(*MemCachedStore).Seek will return sorted list. The only thing
that remains is to sort items got from (*MemoryStore).Seek.
 2021-10-21 10:05:12 +03:00
Anna Shaleva
191cc45032 core: sort items in MemoryStore.Seek 
MemoryStore is used in a MemCachedStore as a persistent layer in tests.
Further commits suppose that persistent storage returns sorted values
from Seek, so sort the result of MemoryStore.Seek.

Benchmark results for 10000 matching items in MemoryStore compared to
master:
name          old time/op    new time/op    delta
MemorySeek-8     712µs ± 0%    3850µs ± 0%   +440.52%  (p=0.000 n=8+8)

name          old alloc/op   new alloc/op   delta
MemorySeek-8     160kB ± 0%    2724kB ± 0%  +1602.61%  (p=0.000 n=10+8)

name          old allocs/op  new allocs/op  delta
MemorySeek-8     10.0k ± 0%     10.0k ± 0%     +0.24%  (p=0.000 n=10+10)

For details on implementation efficiency see the
https://github.com/nspcc-dev/neo-go/pull/2193#discussion_r722993358.
 2021-10-21 10:05:12 +03:00
Anna Shaleva
d8210c0137 core: add benchmarks for iterator.Next, MemCached.Seek, Mem.Seek 2021-10-21 10:05:12 +03:00
Anna Shaleva
8d8071f97e core: distinguish storage.KeyValue and storage.KeyValueExists 
We need Exists field for storage batch related code; other cases may go
without Exists, so add new KeyValue structure and refactor related code.
 2021-10-21 10:05:12 +03:00
Roman Khimov
5ed0be9c27
Merge pull request #2224 from nspcc-dev/fix-privnet 
.docker: dynamically allocate IP for privnet
 2021-10-20 16:18:10 +03:00
Evgeniy Stratonikov
bc78dbf01c .docker: dynamically allocate IP for privnet 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-10-20 13:21:14 +03:00
Roman Khimov
66f2bb1b03
Merge pull request #2218 from nspcc-dev/shellcheck 
.docker: fix shellcheck issues
 2021-10-19 17:39:43 +03:00